From: Theodore Tso <tytso@MIT.EDU>
To: Mingming Cao <cmm@us.ibm.com>
Cc: linux-ext4@vger.kernel.org
Subject: Re: [PATCH, RFC] jbd2: Add commit time into the commit block
Date: Tue, 25 Mar 2008 16:38:21 -0400 [thread overview]
Message-ID: <20080325203821.GO16358@mit.edu> (raw)
In-Reply-To: <1206471469.3617.5.camel@localhost.localdomain>
On Tue, Mar 25, 2008 at 11:57:49AM -0700, Mingming Cao wrote:
> On Sat, 2008-03-15 at 20:59 -0400, Theodore Ts'o wrote:
> > Carlo Wood has demonstrated that it's possible to recover deleted
> > files from the journal. Something that will make this easier is if we
> > can put the time of the commit into commit block.
> >
> Sounds good. Added to the patch queue after fix the compile error.
>
> Shouldn't this a JBD2 INCOMPAT feature?
No, because we're just writing some extra data at the end of the
commit record. There's no imcompatibility implied, since both the
kernel and e2fsck will ignore the extra information.
This is the same reasoning used for why we can add new superblock
fields without needing new compatibility flags, as long as a default
value of 0 does something sane.
- Ted
prev parent reply other threads:[~2008-03-25 20:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-16 0:59 [PATCH, RFC] jbd2: Add commit time into the commit block Theodore Ts'o
2008-03-16 1:23 ` Andreas Dilger
2008-03-16 1:26 ` Andreas Dilger
2008-03-16 3:10 ` Theodore Tso
2008-03-16 15:16 ` Andreas Dilger
2008-03-16 18:52 ` Theodore Tso
2008-03-25 18:57 ` Mingming Cao
2008-03-25 20:38 ` Theodore Tso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080325203821.GO16358@mit.edu \
--to=tytso@mit.edu \
--cc=cmm@us.ibm.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.