All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Marcus Better <marcus@better.se>
Cc: stefanr@s5r6.in-berlin.de, bugme-daemon@bugzilla.kernel.org,
	linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [Bugme-new] [Bug 10327] New: keyboard stops responding after "ifdown eth0"
Date: Wed, 26 Mar 2008 10:29:31 -0700	[thread overview]
Message-ID: <20080326102931.484285f3.akpm@linux-foundation.org> (raw)
In-Reply-To: <47EA152C.6000008@better.se>

On Wed, 26 Mar 2008 10:19:40 +0100
Marcus Better <marcus@better.se> wrote:

> Andrew Morton wrote:
> > 	( sleep 10 ; echo t > /proc/sysrq-trigger ) &
> > 	ifdown eth0
> > 
> > 
> > - See if the sysrq-t output made it to /var/log/messages
> 
> No, not a word. It hung after printing this:
> 
> ...
> DHCPRELEASE ...
> send_packet: Network is unreachable
> send_packet: please consult README ...
> sky2 eth0: disabling interface
> ~# sky2 eth0: enabling interface
> 
> I'm running ifplugd, but this time there was no network cable connected. 
> Also ran from virtual console this time, the keyboard locked up like before.
> 
> SysRq keys work, so I could do sysrq-s, sysrq-b. Also pressed sysrq-t 
> before rebooting.

It certainy does sound like networking has gummed up the keventd queue(s).

> Any use trying netconsole? Can I run it over the wireless interface?

I don't think many (or any?) wireless drivers support netconsole.

I'd suggest running (and perhaps suitably modifying) this:

diff -puN drivers/net/sky2.c~a drivers/net/sky2.c
--- a/drivers/net/sky2.c~a
+++ a/drivers/net/sky2.c
@@ -50,6 +50,8 @@
 
 #include "sky2.h"
 
+#define D() printk("%s:%d\n", __FILE__, __LINE__)
+
 #define DRV_NAME		"sky2"
 #define DRV_VERSION		"1.21"
 #define PFX			DRV_NAME " "
@@ -2931,32 +2933,42 @@ static void sky2_restart(struct work_str
 	struct net_device *dev;
 	int i, err;
 
+	D();
 	rtnl_lock();
+	D();
 	for (i = 0; i < hw->ports; i++) {
+		D();
 		dev = hw->dev[i];
 		if (netif_running(dev))
 			sky2_down(dev);
 	}
-
+	D();
 	napi_disable(&hw->napi);
+	D();
 	sky2_write32(hw, B0_IMSK, 0);
 	sky2_reset(hw);
 	sky2_write32(hw, B0_IMSK, Y2_IS_BASE);
 	napi_enable(&hw->napi);
-
+	D();
 	for (i = 0; i < hw->ports; i++) {
+		D();
 		dev = hw->dev[i];
 		if (netif_running(dev)) {
+			D();
 			err = sky2_up(dev);
+			D();
 			if (err) {
+				D();
 				printk(KERN_INFO PFX "%s: could not restart %d\n",
 				       dev->name, err);
 				dev_close(dev);
+			D();
 			}
 		}
 	}
-
+	D();
 	rtnl_unlock();
+	D();
 }
 
 static inline u8 sky2_wol_supported(const struct sky2_hw *hw)
_

to see if things are getting stuck and if so, where.

  reply	other threads:[~2008-03-26 17:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <bug-10327-10286@http.bugzilla.kernel.org/>
2008-03-25 21:39 ` [Bugme-new] [Bug 10327] New: keyboard stops responding after "ifdown eth0" Andrew Morton
2008-03-25 21:43   ` Marcus Better
2008-03-26  0:01     ` Stefan Richter
2008-03-26  0:16       ` Andrew Morton
2008-03-26  9:19         ` Marcus Better
2008-03-26 17:29           ` Andrew Morton [this message]
2008-04-11 11:12             ` Marcus Better
2008-03-26  8:47   ` [Bugme-new] " Marcus Better

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080326102931.484285f3.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bugme-daemon@bugzilla.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcus@better.se \
    --cc=netdev@vger.kernel.org \
    --cc=stefanr@s5r6.in-berlin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.