From: Jens Axboe <jens.axboe@oracle.com>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] set relay file can not be read by pread(2)
Date: Wed, 26 Mar 2008 12:01:23 +0100 [thread overview]
Message-ID: <20080326110121.GA15355@kernel.dk> (raw)
In-Reply-To: <47E9FEF5.4080606@cn.fujitsu.com>
On Wed, Mar 26 2008, Lai Jiangshan wrote:
> Hi:
> I found that relay files can be read by pread(2). I fix it,
> for relay files are not capable of seeking.
>
> Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
>
> --- linux-2.6.24/kernel/relay.c.org 2008-01-25 06:58:37.000000000 +0800
> +++ linux-2.6.24/kernel/relay.c 2008-03-17 23:53:14.000000000 +0800
> @@ -741,7 +741,7 @@ static int relay_file_open(struct inode
> kref_get(&buf->kref);
> filp->private_data = buf;
>
> - return 0;
> + return nonseekable_open(inode, filp);
> }
>
> /**
Good catch. I'll add it for 2.6.25.
--
Jens Axboe
prev parent reply other threads:[~2008-03-26 11:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 7:44 [PATCH] set relay file can not be read by pread(2) Lai Jiangshan
2008-03-26 11:01 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326110121.GA15355@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.