All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 1/3] hwmon (dme1737): demacrofy for
Date: Wed, 26 Mar 2008 10:08:14 +0000	[thread overview]
Message-ID: <20080326110814.5116bf89@hyperion.delvare> (raw)
In-Reply-To: <47E9D5BE.8020905@gmail.com>

Hi Juerg,

On Tue, 25 Mar 2008 21:49:02 -0700, Juerg Haefliger wrote:
> This patch gets rid of a couple of macros previously used for sysfs 
> attribute generation and manipulation. This makes the source a little 
> bigger but a lot more readable and maintainable. It also fixes an issue 
> with pwm5 & pwm6 attributes not being created read-only initially.

Note that separate patches are preferred in this case, to better
differentiate bug fixes (which distributions might want to backport)
from code cleanups.

> Signed-Off-By: Juerg Haefliger <juergh at gmail.com>

Looks OK to me.

Acked-by: Jean Delvare <khali@linux-fr.org>

-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

  reply	other threads:[~2008-03-26 10:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-26  4:49 [lm-sensors] [PATCH 1/3] hwmon (dme1737): demacrofy for readability Juerg Haefliger
2008-03-26 10:08 ` Jean Delvare [this message]
2008-05-26 15:54 ` [lm-sensors] [PATCH 1/3] hwmon (dme1737): demacrofy for Mark M. Hoffman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080326110814.5116bf89@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.