From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function
Date: Wed, 26 Mar 2008 11:14:34 +0100 [thread overview]
Message-ID: <200803261114.34582.sr@denx.de> (raw)
In-Reply-To: <20080326110618.530c1e82@hskinnemo-gx620.norway.atmel.com>
On Wednesday 26 March 2008, Haavard Skinnemoen wrote:
> > Using Markus's idea, why not use a cpu (platform) specific *and* a board
> > specific init function, both with an empty weak alias in the common eth.c
> > code:
> >
> > cpu_eth_init(bis);
> > board_eth_init(bis);
>
> Why?
>
> The whole point about this exercise is to get rid of board-specific
> knowledge in the common code. What is the purpose of cpu_eth_init()?
Because on PPC4xx for example, all boards are using exactly the same eth_init
code (for the SoC interfaces). And I don't like adding this code to more than
80 boards.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
next prev parent reply other threads:[~2008-03-26 10:14 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-22 2:46 [U-Boot-Users] [RFC][PATCH 1/1] Add board_eth_init() function Ben Warren
2008-03-22 5:03 ` Shinya Kuribayashi
[not found] ` <f8328f7c0803220505n39c9ddb5sf9c9cf037b8f4665@mail.gmail.com>
2008-03-22 12:07 ` Ben Warren
2008-03-22 15:55 ` Vlad Lungu
2008-03-23 6:19 ` Shinya Kuribayashi
2008-03-26 10:00 ` Haavard Skinnemoen
2008-03-26 11:39 ` Shinya Kuribayashi
2008-03-26 12:41 ` Haavard Skinnemoen
2008-03-26 14:15 ` Ben Warren
2008-03-26 14:27 ` Haavard Skinnemoen
2008-03-22 6:31 ` Stefan Roese
2008-03-22 9:59 ` Wolfgang Denk
2008-03-22 10:14 ` Stefan Roese
2008-03-22 11:35 ` Markus Klotzbücher
2008-03-22 14:01 ` Wolfgang Denk
2008-03-22 15:43 ` Ben Warren
2008-03-25 7:04 ` Stefan Roese
2008-03-25 11:11 ` Ben Warren
2008-03-25 14:22 ` Ben Warren
2008-03-25 14:41 ` Joakim Tjernlund
2008-03-25 14:57 ` Ben Warren
2008-03-25 15:31 ` Joakim Tjernlund
2008-03-25 15:56 ` Jerry Van Baren
2008-03-25 16:59 ` Joakim Tjernlund
2008-03-25 14:43 ` Stefan Roese
2008-03-25 16:17 ` Andy Fleming
2008-03-25 16:33 ` Stefan Roese
2008-03-25 17:04 ` Andy Fleming
2008-03-25 17:53 ` Ben Warren
2008-03-26 10:06 ` Haavard Skinnemoen
2008-03-26 10:14 ` Stefan Roese [this message]
2008-03-26 10:25 ` Haavard Skinnemoen
2008-03-26 10:34 ` Stefan Roese
2008-03-26 11:06 ` Haavard Skinnemoen
2008-03-26 11:43 ` Stefan Roese
2008-03-26 12:19 ` Haavard Skinnemoen
2008-03-26 12:39 ` Stefan Roese
2008-03-23 0:06 ` [U-Boot-Users] [OT] Using MTD to manipulate CFI flash on PCI boards? David Hawkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803261114.34582.sr@denx.de \
--to=sr@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.