From: David Gibson <david@gibson.dropbear.id.au>
To: Jon Loeliger <jdl@jdl.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: dtc: Trivial formatting fixes
Date: Thu, 27 Mar 2008 09:30:38 +1100 [thread overview]
Message-ID: <20080326223038.GA5777@localhost.localdomain> (raw)
In-Reply-To: <E1JeVTb-0005tQ-Ae@jdl.com>
On Wed, Mar 26, 2008 at 08:15:35AM -0500, Jon Loeliger wrote:
> > This patch fixes some trivial indentation and brace/bracket style
> > problems.
>
>
> > @@ -179,9 +179,8 @@
> > arg = argv[optind];
> >
> > /* minsize and padsize are mutually exclusive */
> > - if ((minsize) && (padsize)) {
> > + if (minsize && padsize)
> > die("Can't set both -p and -S\n");
> > - }
>
>
> I do not consider extra braces a "problem", and will
> not be applying those changes. The other indentation
> fixes will be applied, of course.
Meh, whatever. Usual kernel style - which is what I originally
adopted for dtc - says no braces for one line blocks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
prev parent reply other threads:[~2008-03-26 22:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 5:21 dtc: Trivial formatting fixes David Gibson
2008-03-26 13:15 ` Jon Loeliger
2008-03-26 22:30 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080326223038.GA5777@localhost.localdomain \
--to=david@gibson.dropbear.id.au \
--cc=jdl@jdl.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.