From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU Date: Thu, 27 Mar 2008 00:54:03 -0700 Message-ID: <20080327005403.18d6ab07.akpm@linux-foundation.org> References: <120648043867-git-send-email-yorksun@freescale.com> <12064804383051-git-send-email-yorksun@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from sc8-sf-mx2-b.sourceforge.net ([10.3.1.92] helo=mail.sourceforge.net) by sc8-sf-list1-new.sourceforge.net with esmtp (Exim 4.43) id 1JemwL-0001f4-7z for linux-fbdev-devel@lists.sourceforge.net; Thu, 27 Mar 2008 00:54:30 -0700 Received: from smtp1.linux-foundation.org ([140.211.169.13]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1JemwJ-0007vx-SY for linux-fbdev-devel@lists.sourceforge.net; Thu, 27 Mar 2008 00:54:25 -0700 In-Reply-To: <12064804383051-git-send-email-yorksun@freescale.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-fbdev-devel-bounces@lists.sourceforge.net Errors-To: linux-fbdev-devel-bounces@lists.sourceforge.net To: York Sun Cc: linux-fbdev-devel@lists.sourceforge.net, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, galak@kernel.crashing.org, linuxppc-dev@ozlabs.org, Timur Tabi On Tue, 25 Mar 2008 16:27:17 -0500 York Sun wrote: > +#if defined(CONFIG_NOT_COHERENT_CACHE) > +unsigned int *coherence_data; > +phys_addr_t *coherence_data_phy; > +#endif These identifiers are too general for use as global symbols. I'd suggest renaming them to diu_coherence_data and diu_coherence_data_phy. Or make them static - I didn't check. I'll duck this version of the patches, as Scott's comments looked rather substantial. ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://ad.doubleclick.net/clk;164216239;13503038;w?http://sf.net/marketplace From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp1.linux-foundation.org (smtp1.linux-foundation.org [140.211.169.13]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "smtp.linux-foundation.org", Issuer "CA Cert Signing Authority" (verified OK)) by ozlabs.org (Postfix) with ESMTPS id B79E5DDE00 for ; Thu, 27 Mar 2008 18:54:28 +1100 (EST) Date: Thu, 27 Mar 2008 00:54:03 -0700 From: Andrew Morton To: York Sun Subject: Re: [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU Message-Id: <20080327005403.18d6ab07.akpm@linux-foundation.org> In-Reply-To: <12064804383051-git-send-email-yorksun@freescale.com> References: <120648043867-git-send-email-yorksun@freescale.com> <12064804383051-git-send-email-yorksun@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: linux-fbdev-devel@lists.sourceforge.net, a.p.zijlstra@chello.nl, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, Timur Tabi List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 25 Mar 2008 16:27:17 -0500 York Sun wrote: > +#if defined(CONFIG_NOT_COHERENT_CACHE) > +unsigned int *coherence_data; > +phys_addr_t *coherence_data_phy; > +#endif These identifiers are too general for use as global symbols. I'd suggest renaming them to diu_coherence_data and diu_coherence_data_phy. Or make them static - I didn't check. I'll duck this version of the patches, as Scott's comments looked rather substantial. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756802AbYC0Hyj (ORCPT ); Thu, 27 Mar 2008 03:54:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753816AbYC0Hya (ORCPT ); Thu, 27 Mar 2008 03:54:30 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:46691 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753519AbYC0Hy3 (ORCPT ); Thu, 27 Mar 2008 03:54:29 -0400 Date: Thu, 27 Mar 2008 00:54:03 -0700 From: Andrew Morton To: York Sun Cc: linux-fbdev-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org, galak@kernel.crashing.org, a.p.zijlstra@chello.nl, Timur Tabi Subject: Re: [PATCH 1/2 v3] Driver for Freescale 8610 and 5121 DIU Message-Id: <20080327005403.18d6ab07.akpm@linux-foundation.org> In-Reply-To: <12064804383051-git-send-email-yorksun@freescale.com> References: <120648043867-git-send-email-yorksun@freescale.com> <12064804383051-git-send-email-yorksun@freescale.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 25 Mar 2008 16:27:17 -0500 York Sun wrote: > +#if defined(CONFIG_NOT_COHERENT_CACHE) > +unsigned int *coherence_data; > +phys_addr_t *coherence_data_phy; > +#endif These identifiers are too general for use as global symbols. I'd suggest renaming them to diu_coherence_data and diu_coherence_data_phy. Or make them static - I didn't check. I'll duck this version of the patches, as Scott's comments looked rather substantial.