From: Andrew Morton <akpm@linux-foundation.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: jeff@garzik.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] pata_atiixp: Simplex clear
Date: Thu, 27 Mar 2008 01:34:38 -0700 [thread overview]
Message-ID: <20080327013438.cc2a69b6.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080326113503.7c0218ce@core>
On Wed, 26 Mar 2008 11:35:03 +0000 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> Some of the other quirks changes seem to have left some users with the
> simplex bits mis-set by the time the driver loads. Clear simplex mode
> before we probe the controller therefore
>
Changelog whine: I am unable to work out from the above whether this patch
is appropriate to 2.6.24.x and/or 2.6.25. It _looks_ like this change will
unbreak some people's stuff, but that's a mad guess.
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.25-rc5-mm1/drivers/ata/pata_atiixp.c linux-2.6.25-rc5-mm1/drivers/ata/pata_atiixp.c
> --- linux.vanilla-2.6.25-rc5-mm1/drivers/ata/pata_atiixp.c 2008-03-18 15:52:08.000000000 +0000
> +++ linux-2.6.25-rc5-mm1/drivers/ata/pata_atiixp.c 2008-03-26 09:41:09.000000000 +0000
> @@ -22,7 +22,7 @@
> #include <linux/libata.h>
>
> #define DRV_NAME "pata_atiixp"
> -#define DRV_VERSION "0.4.6"
> +#define DRV_VERSION "0.4.7"
>
> enum {
> ATIIXP_IDE_PIO_TIMING = 0x40,
> @@ -282,6 +282,9 @@
> .port_ops = &atiixp_port_ops
> };
> const struct ata_port_info *ppi[] = { &info, NULL };
> + /* Some of the quirk reconfiguration messes up the simplex
> + flag, so clear it again */
> + ata_pci_clear_simplex(dev);
> return ata_pci_init_one(dev, ppi);
> }
Patch whine: I got a reject here (libata-all changes) and when fixing it I
was pretty confident that the above hunk was in atiixp_init_one(), but
sometimes these things go wrong. Please change your scripts to use `diff
-p'. It helps.
next prev parent reply other threads:[~2008-03-27 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 11:35 [PATCH] pata_atiixp: Simplex clear Alan Cox
2008-03-27 8:34 ` Andrew Morton [this message]
2008-03-27 9:02 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080327013438.cc2a69b6.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.