All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Paul Jackson <pj@sgi.com>, "Huang, Ying" <ying.huang@intel.com>,
	hpa@zytor.com, andi@firstfloor.org, mingo@redhat.com,
	tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/4] x86_64 boot: Add free_early to early reservation machanism
Date: Thu, 27 Mar 2008 13:08:50 +0100	[thread overview]
Message-ID: <20080327120850.GC6589@basil.nowhere.org> (raw)
In-Reply-To: <20080327115851.GD13538@elte.hu>

On Thu, Mar 27, 2008 at 12:58:51PM +0100, Ingo Molnar wrote:
> 
> * Paul Jackson <pj@sgi.com> wrote:
> 
> > Huang wrote:
> > > +		panic("free_early on not reserved area: %lx-%lx!", start, end);
> > 
> > Should that be 'early_panic', not 'panic' ?
> > 
> > (I see a couple more panics in that file, which I wonder
> > if should be early_panic as well ?)
> 
> this should be fixed properly btw: panic() should self-select whether it 
> does an early_panic() or a real panic().

There's also need of a EARLY_BUG, but self selection would be a little
tricky here.

I still have an old patch for this, but I haven't gotten around to submit it
because it turned out the first user of it wasn't a good idea.

-Andi

  reply	other threads:[~2008-03-27 12:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27  7:09 [PATCH -mm 1/4] x86_64 boot: Add free_early to early reservation machanism Huang, Ying
2008-03-27 11:34 ` Paul Jackson
2008-03-27 11:58   ` Ingo Molnar
2008-03-27 12:08     ` Andi Kleen [this message]
2008-03-27 11:40 ` Paul Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080327120850.GC6589@basil.nowhere.org \
    --to=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=pj@sgi.com \
    --cc=tglx@linutronix.de \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.