From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH][TOOLS] libfsimage: portability fixes Date: Thu, 27 Mar 2008 16:13:33 +0100 Message-ID: <200803271613.33880.Christoph.Egger@amd.com> References: <200803261514.33378.Christoph.Egger@amd.com> <18411.31985.471754.46628@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <18411.31985.471754.46628@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thursday 27 March 2008 11:54:41 Ian Jackson wrote: > Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] libfsimage: portabili= ty=20 fixes"): > > -SUBDIRS-y +=3D $(shell env CC=3D"$(CC)" ./check-libext2fs) > > +SUBDIRS-y +=3D $(shell $(SHELL) env CC=3D"$(CC)" ./check-libext2fs) > > What purpose does this serve ? Everytime when I submitted a patch where I changed /bin/bash to /bin/sh John Levon came up with a "Build is broken on Solaris" message. The fix was always the same: Use $(SHELL) as this is explicitely set for Solaris. > > + /* > > + * Make reads from a raw disk sector-aligned. This is a requirement > > + * for NetBSD. Split the read up into to three parts to meet this > > + * requirement. > > + */ > > Please forgive my ignorance: Does NetBSD offer a different (non-raw) > device which does not have this requirement. If so perhaps we should > be using it instead - if not, why not ? The raw device pass requests directly to the underlying device, with only check/adjustments against the partition bounds. Especially it won't try to do read/modify/write for write requests, or expand the read if it's not sector-aligned. The block device doesn't have this restriction, but allows only ONE open, therefore it is not usable by pygrub. It also has other side-effects (as it goes through the buffer cache), it's definitively not useable for th= e=20 NetBSD block device *backend* or for qemu-dm I/O. Christoph =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=E4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=E4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=E4ftsf=FChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy