From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH][TOOLS] libfsimage: portability fixes Date: Thu, 27 Mar 2008 16:16:51 +0100 Message-ID: <200803271616.52383.Christoph.Egger@amd.com> References: <200803261514.33378.Christoph.Egger@amd.com> <18411.32634.344747.246537@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <18411.32634.344747.246537@mariner.uk.xensource.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Jackson Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org On Thursday 27 March 2008 12:05:30 Ian Jackson wrote: > Christoph Egger writes ("[Xen-devel] [PATCH][TOOLS] libfsimage: portabili= ty=20 fixes"): > > -${CC:-gcc} -o ext2-test ext2-test.c -lext2fs >/dev/null 2>&1 > > +if test -z ${CC}; then CC=3D"gcc"; fi > > +${CC} -o ext2-test ext2-test.c -lext2fs >/dev/null 2>&1 > > + > > This also seems to serve no purpose as far as I can tell. This is for the ancient Solaris /bin/sh. If John Levon confirms that this and that the $(SHELL) mentioned in your other mail=20 are NOT needed/required to not break Solaris, you can undo these two change= s. Christoph =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=E4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=E4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=E4ftsf=FChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy