From: Anton Vorontsov <avorontsov@ru.mvista.com>
To: i2c@lm-sensors.org
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 4/5] i2c: MPC837xRDB Power Management and GPIO expander driver
Date: Thu, 27 Mar 2008 23:02:34 +0300 [thread overview]
Message-ID: <20080327200234.GA17818@localhost.localdomain> (raw)
In-Reply-To: <20080327171044.GA1582@localhost.localdomain>
Incidentally I used some weird .config without preemption and
CONFIG_ENABLE_MUST_CHECK. Heh.
[...]
> + * I don't have specifications for the MCU firmware that is used on the
> + * MPC8349E-mITX/MPC837XRDB boards, I found this register and bits positions
> + * by the trial&error method.
> + */
> +#define MCU_REG_CTRL 0x20
> +#define MCU_CTRL_POFF 0x40
> +#define MCU_NUM_GPIO 2
> +
> +struct mcu {
> + spinlock_t lock;
This should be mutex of course, otherwise preemptable kernel
will complain.
[...]
> + gpiochip_remove(&mcu->of_gc.gc);
Should check return value.
--
Anton Vorontsov
email: cboumailru@gmail.com
irc://irc.freenode.net/bd2
prev parent reply other threads:[~2008-03-27 20:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 20:25 [PATCH 4/5] i2c: MPC837xRDB Power Management and GPIO expander driver Anton Vorontsov
2008-03-26 20:25 ` Anton Vorontsov
[not found] ` <20080326202511.GD1772-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-03-26 20:56 ` Timur Tabi
2008-03-26 20:56 ` Timur Tabi
[not found] ` <47EAB885.7000006-KZfg59tc24xl57MIdRCFDg@public.gmane.org>
2008-03-26 22:56 ` Anton Vorontsov
2008-03-26 22:56 ` Anton Vorontsov
2008-03-27 17:10 ` Anton Vorontsov
2008-03-27 17:10 ` Anton Vorontsov
2008-03-27 17:10 ` Anton Vorontsov
2008-03-27 20:02 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080327200234.GA17818@localhost.localdomain \
--to=avorontsov@ru.mvista.com \
--cc=i2c@lm-sensors.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.