All of lore.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Olga Kornievskaia <aglo@umich.edu>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] silence-call-timeout-printk
Date: Thu, 27 Mar 2008 16:23:31 -0400	[thread overview]
Message-ID: <20080327202331.GJ32540@fieldses.org> (raw)
In-Reply-To: <1206648229.15396.2.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>

On Thu, Mar 27, 2008 at 04:03:49PM -0400, Trond Myklebust wrote:
> On Thu, 2008-03-27 at 15:54 -0400, J. Bruce Fields wrote:
> > On Thu, Mar 27, 2008 at 02:49:12PM -0400, Olga Kornievskaia wrote:
> > > When the client's callback server goes away, the server's callback client
> > > tries to contact the server and times out. For nfsd, it is beneficial to
> > > printout a message when the client is unable to contact the server. For
> > > the callback server, the same message is printed yet it is really not
> > > an error. Thus we need a way to silence the message for the callback 
> > > and yet print it for other cases.
> 
> Bring, back,
> Bring, back,
> Oh, bring back my cl_chatty to me...
> 
>   http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=f518e35aec984036903c1003e867f833747a9d79

OK, OK, so, shall we apply a patch that basically just reverts Chuck's
patch there, except that it inverts the meaning and uses the name
cl_quiet instead of cl_chatty?  (On the theory that since the verbose
case is the common case, it's best to let this thing be initialized to 0
and only make the callback code mess with it?)  Or are you nostalgic for
cl_chatty?

--b.

  parent reply	other threads:[~2008-03-27 20:23 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27 18:49 [PATCH 1/1] silence-call-timeout-printk Olga Kornievskaia
2008-03-27 19:54 ` J. Bruce Fields
2008-03-27 20:03   ` Trond Myklebust
     [not found]     ` <1206648229.15396.2.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-03-27 20:23       ` J. Bruce Fields [this message]
2008-03-27 20:31         ` Trond Myklebust
     [not found]           ` <1206649882.15396.17.camel-rJ7iovZKK19ZJLDQqaL3InhyD016LWXt@public.gmane.org>
2008-03-27 20:45             ` J. Bruce Fields
2008-03-27 20:36         ` Talpey, Thomas
     [not found]           ` <EXNANE01kO22ZhCl8ai000001cd-kboziUmgGqYSZCGxjG3uujkOHZLvdrmu@public.gmane.org>
2008-03-27 20:53             ` J. Bruce Fields
2008-03-27 20:57               ` Trond Myklebust
2008-03-28 15:57               ` Talpey, Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080327202331.GJ32540@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=Trond.Myklebust@netapp.com \
    --cc=aglo@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.