All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: Stefan Roese <sr@denx.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] [POWERPC] 4xx: Create common ppc4xx_reset_system() in ppc4xx_soc.c
Date: Fri, 28 Mar 2008 10:56:18 +1100	[thread overview]
Message-ID: <20080327235618.GA16141@localhost.localdomain> (raw)
In-Reply-To: <1206629011-28821-1-git-send-email-sr@denx.de>

On Thu, Mar 27, 2008 at 03:43:31PM +0100, Stefan Roese wrote:
> This patch creates a common system reset routine for all 40x and 44x
> systems. Previously only a 44x routine existed. But since this system
> reset via the debug control register is common for 40x and 44x let's
> share this code for all those platforms in ppc4xx_soc.c.

Well... they're sort of common.  The source looks the same, but the
SPR number of DBCR0 is different on 40x and 44x, which is a
potentially serious gotcha.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

  reply	other threads:[~2008-03-27 23:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-27 14:43 [PATCH] [POWERPC] 4xx: Create common ppc4xx_reset_system() in ppc4xx_soc.c Stefan Roese
2008-03-27 23:56 ` David Gibson [this message]
2008-03-28  0:39   ` Josh Boyer
2008-04-03  1:25 ` Josh Boyer
2008-04-03  5:02   ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080327235618.GA16141@localhost.localdomain \
    --to=david@gibson.dropbear.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.