From: Tony Lindgren <tony@atomide.com>
To: arun c <arunedarath@mistralsolutions.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: Unnecessary line in omapfb_main.c
Date: Fri, 28 Mar 2008 12:30:52 +0200 [thread overview]
Message-ID: <20080328103051.GT24896@atomide.com> (raw)
In-Reply-To: <c656a4d20803250210l7a950409lbc6897b68c27019f@mail.gmail.com>
* arun c <arunedarath@mistralsolutions.com> [080325 11:11]:
> Hi all,
>
> While grepping through the sources i found one unnecessary line in
> omapfb_main.c
>
> The patch is pasted below.
>
> diff --git a/drivers/video/omap/omapfb_main.c b/drivers/video/omap/omapfb_main.c
> index f66b81a..07eb3f0 100644
> --- a/drivers/video/omap/omapfb_main.c
> +++ b/drivers/video/omap/omapfb_main.c
> @@ -559,7 +559,6 @@ static int set_fb_var(struct fb_info *fbi,
> var->xoffset = var->xres_virtual - var->xres;
> if (var->yres + var->yoffset > var->yres_virtual)
> var->yoffset = var->yres_virtual - var->yres;
> - line_size = var->xres * bpp / 8;
>
> if (plane->color_mode == OMAPFB_COLOR_RGB444) {
> var->red.offset = 8; var->red.length = 4;
Indeed looks like dead code as line_size is not used after that line
:) Can you please send the patch with proper Signed-off-by?
Thanks,
Tony
prev parent reply other threads:[~2008-03-28 10:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-25 9:10 Unnecessary line in omapfb_main.c arun c
2008-03-28 10:30 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328103051.GT24896@atomide.com \
--to=tony@atomide.com \
--cc=arunedarath@mistralsolutions.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.