From: "Josef 'Jeff' Sipek" <jeffpc@josefsipek.net>
To: Ruben Porras <ruben.porras@linworks.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] do not test return value of xfs_bmap_*_count_leaves
Date: Fri, 28 Mar 2008 11:46:05 -0400 [thread overview]
Message-ID: <20080328154605.GA28322@josefsipek.net> (raw)
In-Reply-To: <1206719011.8339.6.camel@marzo>
On Fri, Mar 28, 2008 at 04:43:31PM +0100, Ruben Porras wrote:
> These functions, xfs_bmap_count_leaves and xfs_bmap_disk_count_leaves,
> return always 0. Therefore it is not necessary to test the return value.
If it always returns 0, why not make it void?
Josef 'Jeff' Sipek.
--
Hegh QaQ law'
quvHa'ghach QaQ puS
next prev parent reply other threads:[~2008-03-28 15:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 15:43 [PATCH] do not test return value of xfs_bmap_*_count_leaves Ruben Porras
2008-03-28 15:46 ` Josef 'Jeff' Sipek [this message]
2008-04-04 15:08 ` Ruben Porras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328154605.GA28322@josefsipek.net \
--to=jeffpc@josefsipek.net \
--cc=ruben.porras@linworks.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.