From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jonathan del Strother <maillist@steelskies.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: [PATCH] git-gui: Add shortcut keys for Show More/Less Context
Date: Sat, 29 Mar 2008 01:44:40 -0400 [thread overview]
Message-ID: <20080329054440.GP4759@spearce.org> (raw)
In-Reply-To: <57518fd10803280622v3a5f6ae8lcfd35270ab9ede1e@mail.gmail.com>
Jonathan del Strother <maillist@steelskies.com> wrote:
> Bound to Ctrl/Cmd (depending on your platform) + left & right square brackets.
> ---
>
> I'm not at all familiar with Tcl, so I apologise in advance for any
> wrongness. I frequently find myself repeatedly right-clicking->Show
> Less Context in order to stage a specific hunk, seems like a shortcut
> for this would be useful. Thoughts?
Looks good to me. FWIW your patch was sent with a content-type of
format=flawed, so I had to manually unwrap the diff hunk headers
to get it to apply.
I think we should also put these into the menu bar too, like say
the commit menu, so users can see what the keyboard action is to
invoke the increase/decrease.
Also, missing a Signed-off-by line. If you can contribute
this change according to the statement outlined in
Documentation/SubmittingPatches please send me one.
--
Shawn.
prev parent reply other threads:[~2008-03-29 5:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 13:22 [PATCH] git-gui: Add shortcut keys for Show More/Less Context Jonathan del Strother
2008-03-29 5:44 ` Shawn O. Pearce [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080329054440.GP4759@spearce.org \
--to=spearce@spearce.org \
--cc=git@vger.kernel.org \
--cc=maillist@steelskies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.