From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] jiffies.h: Better error message and add "const" where applicable.
Date: Sat, 29 Mar 2008 13:49:24 +0000 [thread overview]
Message-ID: <20080329134923.GD16721@parisc-linux.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0803290930110.20145@localhost.localdomain>
On Sat, Mar 29, 2008 at 09:32:39AM -0400, Robert P. J. Day wrote:
> Add a more informative error message for bad values of HZ, and add
> "const" argument qualification for a couple routines for which it's
> appropriate.
What effect do you think adding the 'const' has? Remember, C is
pass-by-value.
More useful might be to mark the functions with __attribute_const__.
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-03-29 13:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 13:32 [PATCH] jiffies.h: Better error message and add "const" where Robert P. J. Day
2008-03-29 13:46 ` Julia Lawall
2008-03-29 13:49 ` Matthew Wilcox [this message]
2008-03-29 13:50 ` Robert P. J. Day
2008-03-29 13:54 ` Robert P. J. Day
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080329134923.GD16721@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.