From: Al Viro <viro@ZenIV.linux.org.uk>
To: Josh Boyer <jwboyer@gmail.com>
Cc: Al Viro <viro@ftp.linux.org.uk>,
torvalds@linux-foundation.org, wei.zhang@freescale.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix the broken annotations in fsldma
Date: Sat, 29 Mar 2008 18:38:28 +0000 [thread overview]
Message-ID: <20080329183828.GD9785@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1206799322.12155.10.camel@vader.jdub.homelinux.org>
On Sat, Mar 29, 2008 at 09:02:02AM -0500, Josh Boyer wrote:
> On Sat, 2008-03-29 at 03:10 +0000, Al Viro wrote:
> > a) every bitwise declaration will give a unique type; use typedefs.
> > b) no need to bother with the stuff pointed to by iomem pointers, unless
> > it's accessed directly. noderef will force us to use helpers anyway.
> Did you forget to do the s/u{32,64}/v{32,64}/ conversion for this
> struct, or am I just a moron?
See (b) above.
next prev parent reply other threads:[~2008-03-29 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-29 3:10 [PATCH] fix the broken annotations in fsldma Al Viro
2008-03-29 14:02 ` Josh Boyer
2008-03-29 18:38 ` Al Viro [this message]
2008-03-31 2:12 ` Zhang Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080329183828.GD9785@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ftp.linux.org.uk \
--cc=wei.zhang@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.