From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: vfs-2.6 mountinfo
Date: Mon, 31 Mar 2008 18:00:31 +0100 [thread overview]
Message-ID: <20080331170031.GL9785@ZenIV.linux.org.uk> (raw)
In-Reply-To: <E1JgKb1-0006WP-BG@pomaz-ex.szeredi.hu>
On Mon, Mar 31, 2008 at 04:02:47PM +0200, Miklos Szeredi wrote:
> Some hunks from "[patch 4/7] vfs: mountinfo: add mount peer group ID"
> seems to have accidentally leaked into "[PATCH] teach seq_file to
> discard entries", affecting bisectability.
Ugh... Will fix; thanks for spotting - I wonder how that had happened...
> And in "[patch 3/7] vfs: mountinfo: add mount ID" allocation is *not*
> serialized by namespace_sem on the vfs_kern_mount() call path, so this
> is racy AFAICS:
*hrm*
Right you are ;-/ I really don't like the look of that - the real question
here is whether we want vfsmount IDs to exist through the entire lifetime
of vfsmount. If we do, then we need that (and use of vfsmount_lock in
free_vfsmnt() path as it is done now); if not... I'm still tempted to
move allocation to the same place where we attach the damn thing to
some tree...
Anyway, retry variant will do for now, but I still wonder whether it's
really right long-term... Do we want vfsmount IDs to have any exposure
other than that in mountinfo?
parent reply other threads:[~2008-03-31 17:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <E1JgKb1-0006WP-BG@pomaz-ex.szeredi.hu>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080331170031.GL9785@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.