From: Theodore Tso <tytso@MIT.EDU>
To: linux-ext4@vger.kernel.org
Cc: Andreas Dilger <adilger@dilger.ca>
Subject: Re: [PATCH, E2FSPROGS] ext2fs_set_gdt_csum(): Force the last block group to have a valid block bitmap
Date: Mon, 31 Mar 2008 19:52:04 -0400 [thread overview]
Message-ID: <20080331235204.GD11828@mit.edu> (raw)
In-Reply-To: <1207006592-13980-5-git-send-email-tytso@mit.edu>
On Mon, Mar 31, 2008 at 07:36:26PM -0400, Theodore Ts'o wrote:
> From: Andreas Dilger <adilger@dilger.ca>
>
> Never set the UNINIT_BLOCKS flag for the last group since the kernel
> doesn't handle the case graefully if there is a full set of blocks in
> each blockgroup marked UNINIT_BLOCKS. The kernel should be fixed up,
> but in the meantime this avoids hitting the problem, and is more
> consistent with lazy_bg not marking the last group UNINIT.
This is technically not necessary since we will only set UNINIT_BLOCKS
if the number of free blocks is equal to blocks_per_group minus
superblock_overhead. So there was no danger in the existing codepath.
I think you did this because you were enforcing no UNINIT_BLOCKS in
the last group in e2fsck, instead of just checking to make sure the
free blocks equals the return value from ext2fs_super_and_bgd_loc().
- Ted
next prev parent reply other threads:[~2008-03-31 23:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-17 13:28 Respin of the uninit_group patches Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 01/11] Add initial checksum support for the gdt_checksum/uninit_group feature Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 02/11] Add uninit block group support to various libext2fs functions Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 03/11] Rename feature name from gdt_checksum to uninit_groups Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 04/11] Add support for creating filesystems using uninit block group Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 05/11] Make tune2fs uninit block group aware Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 06/11] Make dumpe2fs " Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 07/11] Make resize2fs " Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 08/11] Make debugfs " Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 09/11] Make e2fsck " Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 10/11] Add new m_lazy test case Theodore Ts'o
2008-03-17 13:28 ` [PATCH, REWORKED 11/11] Add m_uninit " Theodore Ts'o
2008-03-17 17:22 ` [PATCH, REWORKED 01/11] Add initial checksum support for the gdt_checksum/uninit_group feature Andreas Dilger
2008-03-17 18:05 ` Theodore Tso
2008-03-18 0:26 ` Andreas Dilger
2008-03-18 23:33 ` Respin of the uninit_group patches Andreas Dilger
2008-03-25 8:40 ` Andreas Dilger
2008-03-31 23:36 ` [PATCH, E2FSPROGS] Improve ext4 feature descriptions in mke2fs and tune2fs man pages Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] Fix the copyright notice in lib/ext2fs/tst_csum.c to be GPLv2 only Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] debugfs: Add support for "set_block_group <bg_num> checksum calc" Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] ext2fs_set_gdt_csum(): Clean up superblock dirty flag handling Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] ext2fs_set_gdt_csum(): Force the last block group to have a valid block bitmap Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] ext2fs_set_gdt_csum(): Return an error code on errors instead of void Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] libext2fs: Micro-optimization in inode scan code Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] Split the m_lazy test case into two cases: m_lazy and m_lazy_resize Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] e2fsck: Add check to enforce a valid block bitmap in last block group Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] Fix trailing whitespace in e2fsck/problem.[ch] Theodore Ts'o
2008-03-31 23:36 ` [PATCH, E2FSPROGS] Add new regression test: f_uninit_last_uninit Theodore Ts'o
2008-04-01 0:00 ` [PATCH, E2FSPROGS] Fix trailing whitespace in e2fsck/problem.[ch] Theodore Tso
2008-03-31 23:53 ` [PATCH, E2FSPROGS] ext2fs_set_gdt_csum(): Return an error code on errors instead of void Theodore Tso
2008-03-31 23:52 ` Theodore Tso [this message]
2008-03-31 23:47 ` [PATCH, E2FSPROGS] ext2fs_set_gdt_csum(): Clean up superblock dirty flag handling Theodore Tso
2008-03-31 23:46 ` [PATCH, E2FSPROGS] debugfs: Add support for "set_block_group <bg_num> checksum calc" Theodore Tso
2008-03-25 9:15 ` Respin of the uninit_group patches Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080331235204.GD11828@mit.edu \
--to=tytso@mit.edu \
--cc=adilger@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.