From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757383AbYDAJLQ (ORCPT ); Tue, 1 Apr 2008 05:11:16 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753253AbYDAJLD (ORCPT ); Tue, 1 Apr 2008 05:11:03 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:51496 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753393AbYDAJLB (ORCPT ); Tue, 1 Apr 2008 05:11:01 -0400 Date: Tue, 1 Apr 2008 02:09:46 -0700 From: Andrew Morton To: Rodolfo Giometti Cc: linux-kernel@vger.kernel.org, David Woodhouse , Dave Jones , Sam Ravnborg , Greg KH , Randy Dunlap Subject: Re: [PATCH 1/7] LinuxPPS core support. Message-Id: <20080401020946.a62ee645.akpm@linux-foundation.org> In-Reply-To: <20080401085950.GZ7279@enneenne.com> References: <12048053463198-git-send-email-giometti@linux.it> <12048053473401-git-send-email-giometti@linux.it> <20080328032139.7af69ff9.akpm@linux-foundation.org> <20080401085950.GZ7279@enneenne.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Apr 2008 10:59:50 +0200 Rodolfo Giometti wrote: > On Fri, Mar 28, 2008 at 03:21:39AM -0700, Andrew Morton wrote: > > On Thu, 6 Mar 2008 13:09:00 +0100 Rodolfo Giometti wrote: > > > > > This patch adds the kernel side of the PPS support currently named > > > "LinuxPPS". > > > > powerpc: > > > > drivers/pps/pps.c: In function 'pps_cdev_ioctl': > > drivers/pps/pps.c:166: warning: format '%lld' expects type 'long long int', but argument 2 has type '__s64' > > drivers/pps/kapi.c: In function 'pps_event': > > drivers/pps/kapi.c:225: warning: format '%llu' expects type 'long long unsigned int', but argument 3 has type '__s64' > > drivers/pps/sysfs.c: In function 'pps_show_assert': > > drivers/pps/sysfs.c:42: warning: format '%lld' expects type 'long long int', but argument 3 has type '__s64' > > drivers/pps/sysfs.c:42: warning: format '%lld' expects type 'long long int', but argument 3 has type '__s64' > > drivers/pps/sysfs.c: In function 'pps_show_clear': > > drivers/pps/sysfs.c:56: warning: format '%lld' expects type 'long long int', but argument 3 has type '__s64' > > drivers/pps/sysfs.c:56: warning: format '%lld' expects type 'long long int', but argument 3 has type '__s64' > > Oops! I have no powerpc system... how can I solve this issue? Use %lld (if these things can legitimately be negative - otherwise %llu) and cast the argument to (long long) or (unsigned long long).