From: Andrew Morton <akpm@linux-foundation.org>
To: David Miller <davem@davemloft.net>
Cc: kosaki.motohiro@jp.fujitsu.com, csnook@redhat.com,
davej@codemonkey.org.uk, nickpiggin@yahoo.com.au,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: GFP_ATOMIC page allocation failures.
Date: Wed, 2 Apr 2008 01:43:17 -0700 [thread overview]
Message-ID: <20080402014317.7634515f.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080402.012406.246863209.davem@davemloft.net>
On Wed, 02 Apr 2008 01:24:06 -0700 (PDT) David Miller <davem@davemloft.net> wrote:
> From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Date: Wed, 02 Apr 2008 17:17:50 +0900
>
> > if network guys hope known-good driver should call
> > __netdev_alloc_skb(dev, length, GFP_ATOMIC|__GFP_NOWARN) instead netdev_alloc_skb,
> > I think we should make netdev_alloc_skb_nowarn.
>
> Giving it a proper name like this takes away the indication that this
> situation is very special.
>
> Two leading underscores to an interface means "something special and
> unusual requiring more careful consideration than usual is occuring
> here." netdev_alloc_skb_nowarn() on the other hand, does not
> convey this meaning.
>
> And we will have very few drivers that use this construct, thus it
> really is best to handle things the way Andrew has.
Oh. I just went and redid thing the other way. Picked the same name too.
Whatever.
next prev parent reply other threads:[~2008-04-02 8:44 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-01 23:56 GFP_ATOMIC page allocation failures Dave Jones
2008-04-02 1:28 ` Nick Piggin
2008-04-02 1:35 ` Dave Jones
2008-04-02 6:28 ` Chris Snook
2008-04-02 7:56 ` Andrew Morton
2008-04-02 8:17 ` KOSAKI Motohiro
2008-04-02 8:24 ` David Miller
2008-04-02 8:43 ` Andrew Morton [this message]
2008-04-02 10:00 ` KOSAKI Motohiro
2008-04-02 10:56 ` KOSAKI Motohiro
2008-04-02 18:44 ` David Miller
2008-04-02 20:12 ` Michael Chan
2008-04-02 20:53 ` David Miller
2008-04-02 11:04 ` Peter Zijlstra
2008-04-02 18:45 ` David Miller
2008-04-02 19:06 ` Jeff Garzik
2008-04-02 9:12 ` Nick Piggin
2008-04-02 15:54 ` Andrew Morton
2008-04-03 5:22 ` Nick Piggin
2008-04-03 5:32 ` Andrew Morton
2008-04-03 8:59 ` Evgeniy Polyakov
2008-06-26 21:06 ` Dave Jones
2008-06-26 22:26 ` Chris Snook
2008-06-26 22:26 ` Chris Snook
2008-06-27 10:01 ` Evgeniy Polyakov
2008-06-27 10:01 ` Evgeniy Polyakov
2008-04-02 17:21 ` Jeff Garzik
2008-04-02 17:33 ` Andrew Morton
2008-04-02 18:18 ` Jeff Garzik
2008-04-02 18:37 ` Kok, Auke
2008-04-03 5:57 ` Nick Piggin
2008-04-03 18:20 ` Jeff Garzik
[not found] <adYyJ-20N-11@gated-at.bofh.it>
[not found] ` <aef6w-6rx-45@gated-at.bofh.it>
[not found] ` <aefJ9-7KR-15@gated-at.bofh.it>
[not found] ` <aeqF6-45P-29@gated-at.bofh.it>
2008-04-04 9:52 ` Bodo Eggert
2008-04-04 9:52 ` Bodo Eggert
2008-04-04 10:59 ` Nick Piggin
2008-04-04 11:35 ` Bodo Eggert
2008-04-05 1:06 ` Nick Piggin
2008-04-06 12:12 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080402014317.7634515f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=csnook@redhat.com \
--cc=davej@codemonkey.org.uk \
--cc=davem@davemloft.net \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.