Re: [PATCH 1/2] sysfs: allow the group is_visible() method to return a mode and add an update API

[Greg KH <greg@kroah.com>]

On Mon, Mar 31, 2008 at 03:42:09PM +0200, Kay Sievers wrote:
> On Sun, 2008-03-30 at 11:54 -0500, James Bottomley wrote:
> > On Sat, 2008-03-22 at 13:02 -0500, James Bottomley wrote:
> > > On Fri, 2008-03-21 at 15:26 -0700, Greg KH wrote:
> > > > On Fri, Mar 21, 2008 at 04:27:12PM -0500, James Bottomley wrote:
> > > > > We have a problem in scsi_transport_spi in that we need to customise
> > > > > not only the visibility of the attributes, but also their mode.  Fix
> > > > > this by making the is_visible() callback return a mode, with 0
> > > > > indicating is not visible.
> > > > > 
> > > > > Also add a sysfs_update_group() API to allow us to change either the
> > > > > visibility or mode of the files at any time on the fly.
> > > > > 
> > > > > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> > > > > ---
> > > > > 
> > > > > Greg, can I take this through SCSI, please ... assuming it's OK?  We
> > > > > need this to fix up the SPI transport class.
> > > > 
> > > > Sure.  But can you document that "update" field a bit more so we can
> > > > remember what it means in the future?
> > > 
> > > How about this?  I also added docbook for create and update attribute
> > > group.
> 
> Looks good to me.
> 
> I think with the "visible" stuff for attribute groups, will be able to
> fix the USB event timing problem, by moving the creation of the device
> attributes to default attributes. So I'm looking forward to have this in
> the tree.

Me too.

> > Can I get an ACK from someone from sysfs for this, please?
> 
> > > ---
> > > 
> > > From: James Bottomley <James.Bottomley@HansenPartnership.com>
> > > Date: Thu, 20 Mar 2008 20:47:52 -0500
> > > Subject: [SCSI] sysfs: make group is_valid return a mode_t
> > > 
> > > We have a problem in scsi_transport_spi in that we need to customise
> > > not only the visibility of the attributes, but also their mode.  Fix
> > > this by making the is_visible() callback return a mode, with 0
> > > indicating is not visible.
> > > 
> > > Also add a sysfs_update_group() API to allow us to change either the
> > > visibility or mode of the files at any time on the fly.
> 
> Acked-by: Kay Sievers <kay.sievers@vrfy.org>

Acked-by: Greg Kroah-Hartman <gregkh@suse.de>