From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: [PATCH] incorrect xfree for mini-os Date: Wed, 2 Apr 2008 23:40:27 +0200 Message-ID: <20080402214027.GB6212@implementation> References: <20080402105248.GE4618@implementation.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: INAKOSHI Hiroya , xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Keir Fraser, le Wed 02 Apr 2008 15:45:43 +0100, a écrit : > On 2/4/08 11:52, "Samuel Thibault" wrote: > > > INAKOSHI Hiroya, le Wed 02 Apr 2008 19:43:29 +0900, a écrit : > >> xfree in extras/mini-os/lib/xmalloc.c is incorrect. > >> > >> It has to check first if the memory to free is so big as to be freed > >> directly by free_pages. > >> > >> mini-os domains crash without this patch if they don't configure vfb > >> correctly. > >> > >> Signed-off-by: INAKOSHI Hiroya > > > > Acked-by: Samuel Thibault > > Applied, but shouldn't the checks that this patch skips work okay even for > big allocations made via xmalloc_whole_pages()? The "hdr will be on same page" will typically not work when aligning the big area on pages. Samuel