From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Thu, 03 Apr 2008 19:35:51 +0200 (CEST) Received: from hydra.gt.owl.de ([195.71.99.218]:14058 "EHLO hydra.gt.owl.de") by lappi.linux-mips.net with ESMTP id S526924AbYDCGJA (ORCPT ); Thu, 3 Apr 2008 08:09:00 +0200 Received: by hydra.gt.owl.de (Postfix, from userid 1000) id E6F2232D00; Thu, 3 Apr 2008 08:08:20 +0200 (CEST) Date: Thu, 3 Apr 2008 08:08:20 +0200 From: Florian Lohoff To: Matteo Croce Cc: linux-mips@linux-mips.org, Eugene Konev , Andrew Morton Subject: Re: [PATCH][MIPS][3/6]: AR7: VLYNQ bus Message-ID: <20080403060820.GD26540@paradigm.rfc822.org> References: <200803120221.25044.technoboy85@gmail.com> <200804021456.44472.technoboy85@gmail.com> <20080402183114.GA371@paradigm.rfc822.org> <200804030219.03335.technoboy85@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="GyRA7555PLgSTuth" Content-Disposition: inline In-Reply-To: <200804030219.03335.technoboy85@gmail.com> Organization: rfc822 - pure communication X-SpiderMe: mh-200804030734@listme.rfc822.org User-Agent: Mutt/1.5.13 (2006-08-11) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 18792 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: flo@rfc822.org Precedence: bulk X-list: linux-mips --GyRA7555PLgSTuth Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 03, 2008 at 02:19:03AM +0200, Matteo Croce wrote: > > @@ -371,12 +371,20 @@ static int __vlynq_enable_device(struct=20 > > =20 > > switch (dev->divisor) { > > case vlynq_div_auto: > > - /* Only try locally supplied clock, others cause proble= ms */ > > + =20 > > + vlynq_reg_write(dev->local->control, 0); > > vlynq_reg_write(dev->remote->control, 0); > > + if (vlynq_linked(dev)) { > > + printk(KERN_DEBUG "%s: using external clock\n", > > + dev->dev.bus_id); > > + return 0; > > + } > > + > > for (i =3D vlynq_ldiv2; i <=3D vlynq_ldiv8; i++) { > > vlynq_reg_write(dev->local->control, > > VLYNQ_CTRL_CLOCK_INT | > > VLYNQ_CTRL_CLOCK_DIV(i - vlynq_= ldiv1)); > > + vlynq_reg_write(dev->remote->control, 0); > > if (vlynq_linked(dev)) { > > printk(KERN_DEBUG > > "%s: using local clock divisor %= d\n", > >=20 > > Flo >=20 > isn't this what I do in my last patch? I was shoveling through my inbox top down and the first mail was the original patch i was referring to - sorry for the noise... Flo --=20 Florian Lohoff flo@rfc822.org +49-171-2280134 Those who would give up a little freedom to get a little=20 security shall soon have neither - Benjamin Franklin --GyRA7555PLgSTuth Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFH9HRUUaz2rXW+gJcRAlIjAJ0VUZEpLquWzU9/b/rvmsQQiruIVgCcDVYZ fSBJi7+9L5iIIaF+LsEIm0M= =zGjZ -----END PGP SIGNATURE----- --GyRA7555PLgSTuth--