From: "Peter 'p2' De Schrijver" <peter.de-schrijver@nokia.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/3] I2C: TWL4030: Add power button and power IRQ support
Date: Thu, 3 Apr 2008 16:57:33 +0300 [thread overview]
Message-ID: <20080403135733.GE5199@codecarver.research.nokia.com> (raw)
In-Reply-To: <20080403134705.GY7004@gandalf.research.nokia.com>
Felipe,
> +
> + for (module_irq = IH_TWL4030_PWRBASE; pwr_isr != 0;
> + module_irq++, pwr_isr >>= 1) {
> + if (pwr_isr & 1) {
> + irq_desc_t *d = irq_desc + module_irq;
> + d->handle_irq(module_irq, d);
There is a missing } here.
> + }
> +
> + local_irq_disable();
> + desc->chip->unmask(irq);
> + }
> +}
> +
Cheers,
Peter.
next prev parent reply other threads:[~2008-04-03 13:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 13:44 [PATCH 1/3] I2C: TWL4030: Add power button and power IRQ support Felipe Balbi
2008-04-03 13:44 ` [PATCH 2/3] I2C: TWL4030: Kconfig and Makefile changes Felipe Balbi
2008-04-03 13:44 ` [PATCH 3/3] I2C: TWL4030: Adapt existing drivers to power IRQ Felipe Balbi
2008-04-03 13:47 ` [PATCH 1/3] I2C: TWL4030: Add power button and power IRQ support Felipe Balbi
2008-04-03 13:57 ` Peter 'p2' De Schrijver [this message]
2008-04-03 14:04 ` Felipe Balbi
2008-04-04 9:44 ` Tony Lindgren
2008-04-04 10:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080403135733.GE5199@codecarver.research.nokia.com \
--to=peter.de-schrijver@nokia.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.