Re: [PATCH 5/7] XFS: Unicode case-insensitive lookup implementation

[Jeremy Allison <jra@samba.org>]

On Thu, Apr 03, 2008 at 02:57:17PM -0400, Christoph Hellwig wrote:
> On Thu, Apr 03, 2008 at 02:55:26PM -0400, Christoph Hellwig wrote:
> > On Thu, Apr 03, 2008 at 11:47:39AM -0700, Jeremy Allison wrote:
> > > > CI filenames can work perfectly fine without adding validation of file
> > > > names by treating non-conformant bytestreams as not having lower/upper
> > > > case variants.
> > > 
> > > Sorry, then I'm not understanding your objection to this patch (and I
> > > don't think I understood that sentence :-).
> > 
> > I objected to the part of the patch I've quoted (and the bitsrelated to
> > it), not all of it.  That how we do reviews in kernel land, not sure
> > how samba handles it if you have a binary object/don't object policy..
> 
> oops, look like the quote actually got deleted accidentally.  sorry
> I'ltake that comment back.
> 
> The part I object to are the various calls to xfs_unicode_validate
> in the namespace operations.

Ah, ok - now I understand - thanks ! We also have a finer-grained
objection system than entire patch btw.

Jeremy.