Re: [REGRESSION] git-gui

["Shawn O. Pearce" <spearce@spearce.org>]

"Shawn O. Pearce" <spearce@spearce.org> wrote:
> Jonathan del Strother <maillist@steelskies.com> wrote:
> > >  > >  # git gui
> > >  > >  Error in startup script: bad event type or keysym "["
> > >  > >     while executing
> > >  > >  "bind $ui_comm <$M1B-Key-\[> {show_less_context;break}"
> 
> > >  These changes should help (haven't tried):
> > >         \[ -> bracketleft
> > >         \] -> bracketright
> > >  but some European keyboards do not have easy access to brackets, so
> > >  other keys would be preferable (comma and period, for example, or 1 and 2).
> 
> I wrote up a patch today based on Michele's suggested change.

Hmm, maybe I should offer the patch.  :-)

--8>--
Subject: [PATCH] git-gui: Switch keybindings for [ and ] to bracketleft and bracketright

Thanks to Michele Ballabio for the quick fix.
This resolves the error introduced by c91ee2bd61.

Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
---
 git-gui.sh |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/git-gui.sh b/git-gui.sh
index d4e4c17..1a67105 100755
--- a/git-gui.sh
+++ b/git-gui.sh
@@ -2739,8 +2739,8 @@ bind $ui_comm <$M1B-Key-v> {tk_textPaste %W; %W see insert; break}
 bind $ui_comm <$M1B-Key-V> {tk_textPaste %W; %W see insert; break}
 bind $ui_comm <$M1B-Key-a> {%W tag add sel 0.0 end;break}
 bind $ui_comm <$M1B-Key-A> {%W tag add sel 0.0 end;break}
-bind $ui_comm <$M1B-Key-\[> {show_less_context;break}
-bind $ui_comm <$M1B-Key-\]> {show_more_context;break}
+bind $ui_comm <$M1B-Key-bracketleft> {show_less_context;break}
+bind $ui_comm <$M1B-Key-bracketright> {show_more_context;break}
 
 bind $ui_diff <$M1B-Key-x> {tk_textCopy %W;break}
 bind $ui_diff <$M1B-Key-X> {tk_textCopy %W;break}
@@ -2784,8 +2784,8 @@ bind .   <$M1B-Key-t> do_add_selection
 bind .   <$M1B-Key-T> do_add_selection
 bind .   <$M1B-Key-i> do_add_all
 bind .   <$M1B-Key-I> do_add_all
-bind .   <$M1B-Key-\[> {show_less_context;break}
-bind .   <$M1B-Key-\]> {show_more_context;break}
+bind .   <$M1B-Key-bracketleft> {show_less_context;break}
+bind .   <$M1B-Key-bracketright> {show_more_context;break}
 bind .   <$M1B-Key-Return> do_commit
 foreach i [list $ui_index $ui_workdir] {
 	bind $i <Button-1>       "toggle_or_diff         $i %x %y; break"
-- 
1.5.5.rc3.148.gb77a7


-- 
Shawn.