[Cluster-devel] Cluster Project branch, STABLE2, updated. cluster-2.02.00-34-g2182e21

[fabbione@sourceware.org <fabbione@sourceware.org>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "Cluster Project".

http://sources.redhat.com/git/gitweb.cgi?p=cluster.git;a=commitdiff;h=2182e21187edf46d5d4832abf847fe824893a61c

The branch, STABLE2 has been updated
       via  2182e21187edf46d5d4832abf847fe824893a61c (commit)
      from  3ed90000f931a576c807d3e8ad7602c359f3dd0e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 2182e21187edf46d5d4832abf847fe824893a61c
Author: Jonathan Brassow <jbrassow@redhat.com>
Date:   Thu Apr 3 10:24:21 2008 -0500

    rgmanager/lvm.sh:  Minor comment updates
    
    Just moving/expanding some comments.

-----------------------------------------------------------------------

Summary of changes:
 rgmanager/src/resources/lvm.sh |   14 +++++++++++---
 1 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/rgmanager/src/resources/lvm.sh b/rgmanager/src/resources/lvm.sh
index 3b851d8..4c93249 100755
--- a/rgmanager/src/resources/lvm.sh
+++ b/rgmanager/src/resources/lvm.sh
@@ -55,9 +55,8 @@ function clvm_check
 function ha_lvm_proper_setup_check
 {
 	##
-	# Machine's cluster node name must be present as
-	# a tag in lvm.conf:activation/volume_list and the volume group
-	# to be failed over must NOT be there.
+	# The default for lvm.conf:activation/volume_list is empty,
+	# this must be changed for HA LVM.
 	##
 	if ! lvm dumpconfig activation/volume_list >& /dev/null; then
 		ocf_log err "HA LVM:  Improper setup detected"
@@ -65,12 +64,21 @@ function ha_lvm_proper_setup_check
 		return $OCF_ERR_GENERIC
 	fi
 
+	##
+	# Machine's cluster node name must be present as
+	# a tag in lvm.conf:activation/volume_list
+	##
 	if ! lvm dumpconfig activation/volume_list | grep $(local_node_name); then
 		ocf_log err "HA LVM:  Improper setup detected"
 		ocf_log err "- @$(local_node_name) missing from \"volume_list\" in lvm.conf"
 		return $OCF_ERR_GENERIC
 	fi
 
+	##
+	# The volume group to be failed over must NOT be in
+	# lvm.conf:activation/volume_list; otherwise, machines
+	# will be able to activate the VG regardless of the tags
+	##
 	if lvm dumpconfig activation/volume_list | grep $OCF_RESKEY_vg_name; then
 		ocf_log err "HA LVM:  Improper setup detected"
 		ocf_log err "- $OCF_RESKEY_vg_name found in \"volume_list\" in lvm.conf"


hooks/post-receive
--
Cluster Project