From: Olof Johansson <olof@lixom.net>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] PowerPC: MPIC ack interrupts at mpic_teardown_this_cpu()
Date: Fri, 4 Apr 2008 00:29:55 -0500 [thread overview]
Message-ID: <20080404052955.GC11799@lixom.net> (raw)
In-Reply-To: <1207259436.10388.337.camel@pasglop>
On Fri, Apr 04, 2008 at 08:50:36AM +1100, Benjamin Herrenschmidt wrote:
>
> On Thu, 2008-04-03 at 23:09 +0400, Valentine Barshak wrote:
> > We really need to ack interrupts at mpic_teardown, since
> > not all platforms reset mpic at kernel start-up. For example,
> > kexec'ed kernel hangs on P.A. Semi if mpic_eoi() isn't called.
> >
> > Signed-off-by: Valentine Barshak <vbarshak@ru.mvista.com>
> > ---
>
> Would be interesting to find out why it hangs tho... it shouldn't .
I haven't reproduced the problem and looked at hardware state yet, but I
would expect it to be because the openpic won't send another interrupt
until the previous is EOI'd, and the IPI is never EOI'd as far as I
can tell.
The XICS code does it explicitly already. I'm surprised it doesn't break
on the 970-based platforms actually...
-Olof
next prev parent reply other threads:[~2008-04-04 5:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 19:09 [PATCH] PowerPC: MPIC ack interrupts at mpic_teardown_this_cpu() Valentine Barshak
2008-04-03 21:50 ` Benjamin Herrenschmidt
2008-04-04 5:29 ` Olof Johansson [this message]
2008-04-04 17:38 ` Segher Boessenkool
2008-04-04 18:03 ` Olof Johansson
2008-04-04 18:55 ` Segher Boessenkool
2008-04-04 19:39 ` Olof Johansson
2008-04-07 14:24 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080404052955.GC11799@lixom.net \
--to=olof@lixom.net \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.