From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: Re: [Xen-changelog] [xen-unstable] Clean up handling of IS_PRIV_FOR() and rcu_[un]lock_domain(). Date: Sat, 5 Apr 2008 16:28:14 +0200 Message-ID: <20080405142814.GL4005@implementation> References: <20080329112316.GC4482@implementation> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Hello, Keir Fraser, le Sat 29 Mar 2008 11:47:57 +0000, a écrit : > > IIRC the event channel ops are not needed right now, but will probably > > be in the future. > > They were all fine, except there was one inexplicable check of IS_PRIV_FOR() > in bind_interdomain() which I nuked. It was so bizarre that I assumed you > must have put it there for a reason, and this would be one that you'd > complain about. I'm now complaining :) The bind_interdomain() trick is needed for the ioreq events channel: when it gets installed, it is supposed to be between the HVM domain and dom0 (the stub domain doesn't exist anyway). The meaning of the test is hence to allow the stub domain to hijack that event channel (because it has privileges on the remote domain). With that fix, stub domains are working again (but Cirrus bios doesn't work yet) Samuel