From: Ingo Molnar <mingo@elte.hu>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Andi Kleen <ak@suse.de>, "H. Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, lguest <lguest@ozlabs.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Fix booting pentium+ with dodgy TSC
Date: Sun, 6 Apr 2008 13:22:08 +0200 [thread overview]
Message-ID: <20080406112207.GA26510@elte.hu> (raw)
In-Reply-To: <200804061723.38766.rusty@rustcorp.com.au>
* Rusty Russell <rusty@rustcorp.com.au> wrote:
> Linus please apply. Almost by definition this patch can't make things
> worse.
well, while i agree with the patch it could make things worse. In this
case it can cause code that has been compiled to rely on TSC to
malfunction. For if sched_clock() was using cpu_has_tsc it could return
0 all the time, breaking the scheduler without the user having a clear
idea why it broke. It isnt, and sched_clock() will work fine, but still,
your "this cant make things worse" statement is not completely correct.
In any case:
Acked-by: Ingo Molnar <mingo@elte.hu>
and i've also queued it up into the for-.25 queue of x86.git.
Ingo
next prev parent reply other threads:[~2008-04-06 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-06 7:23 [PATCH] Fix booting pentium+ with dodgy TSC Rusty Russell
2008-04-06 11:22 ` Ingo Molnar [this message]
2008-04-06 20:29 ` Rusty Russell
2008-04-11 15:43 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080406112207.GA26510@elte.hu \
--to=mingo@elte.hu \
--cc=ak@suse.de \
--cc=hpa@zytor.com \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.