From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: trying to avoid "#ifdef CONFIG_NUMA"?
Date: Mon, 07 Apr 2008 12:43:01 +0000 [thread overview]
Message-ID: <20080407124301.GG16451@parisc-linux.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0804070741520.23945@localhost.localdomain>
On Mon, Apr 07, 2008 at 07:45:01AM -0400, Robert P. J. Day wrote:
> /* This helps us to avoid #ifdef CONFIG_NUMA */
> #ifdef CONFIG_NUMA
> #define NUMA_BUILD 1
> #else
> #define NUMA_BUILD 0
> #endif
> mm/page_alloc.c: if (NUMA_BUILD && zlc_active &&
>
> not a lot of avoiding going on there, i'd say.
but it's important where it happens. it would uglify the code
significantly to replace the if (NUMA_BUILD) with #ifdef CONFIG_NUMA.
Maybe NUMA_BUILD should be used in more places, but how about doing
something useful instead?
--
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2008-04-07 12:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 11:45 trying to avoid "#ifdef CONFIG_NUMA"? Robert P. J. Day
2008-04-07 12:43 ` Matthew Wilcox [this message]
2008-04-07 12:56 ` Robert P. J. Day
2008-04-12 11:28 ` Vegard Nossum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080407124301.GG16451@parisc-linux.org \
--to=matthew@wil.cx \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.