From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: trond.myklebust@fys.uio.no, bfields@fieldses.org,
nfsv4@linux-nfs.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NLM: hold BKL when clearing global lockd task and serv vars
Date: Mon, 7 Apr 2008 12:45:01 -0400 [thread overview]
Message-ID: <20080407164500.GA17728@infradead.org> (raw)
In-Reply-To: <1207575514-6703-2-git-send-email-jlayton@redhat.com>
On Mon, Apr 07, 2008 at 09:38:34AM -0400, Jeff Layton wrote:
> The global task and serv pointers for lockd are normally protected by
> the nlmsvc_mutex. The exception is when the lockd exits abnormally. When
> this occurs, these variables are cleared without any locking.
Shouldn't we get rid of the case where it exits abnormally instead?
next prev parent reply other threads:[~2008-04-07 16:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 13:38 [PATCH] NFS: hold BKL when clearing nfs_callback_info.task Jeff Layton
2008-04-07 13:38 ` [PATCH] NLM: hold BKL when clearing global lockd task and serv vars Jeff Layton
2008-04-07 16:45 ` Christoph Hellwig [this message]
2008-04-07 17:40 ` Jeff Layton
2008-04-07 17:56 ` J. Bruce Fields
2008-04-07 19:08 ` Tom Tucker
2008-04-07 20:22 ` Jeff Layton
2008-04-07 20:50 ` J. Bruce Fields
2008-04-08 13:21 ` Jeff Layton
2008-04-08 16:28 ` J. Bruce Fields
2008-04-08 17:02 ` Jeff Layton
2008-04-08 19:16 ` Jeff Layton
2008-04-08 20:08 ` Chuck Lever
2008-04-08 20:20 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080407164500.GA17728@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.