From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denys Vlasenko Date: Mon, 07 Apr 2008 21:18:48 +0000 Subject: Re: [PATCH] drivers/atm/ambassador.c: stop inlining largish static functions Message-Id: <200804072318.48442.vda.linux@googlemail.com> List-Id: References: <200804010314.58117.vda.linux@googlemail.com> In-Reply-To: <200804010314.58117.vda.linux@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org On Friday 04 April 2008 00:00, David Miller wrote: > > This patch removes "inline" from these static functions > > (regardless of number of callsites - gcc nowadays auto-inlines > > statics with one callsite). > > > > Size difference for 32bit x86: > > text data bss dec hex filename > > 10209 8488 4 18701 490d linux-2.6-ALLYES/drivers/atm/ambassador.o > > 9462 8488 4 17954 4622 linux-2.6.inline-ALLYES/drivers/atm/ambassador.o > > > > Signed-off-by: Denys Vlasenko > > I've applied this to net-2.6.26, if John doesn't like it we > can fix it or revert. Thanks. -- vda