From: Andrew Morton <akpm@linux-foundation.org>
To: ego@in.ibm.com
Cc: paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
mathieu.desnoyers@polymtl.ca, mingo@elte.hu, hch@infradead.org,
mmlnx@us.ibm.com, dipankar@in.ibm.com, dsmith@redhat.com,
rostedt@goodmis.org, adrian.bunk@movial.fi,
a.p.zijlstra@chello.nl, niv@us.ibm.com, dvhltc@us.ibm.com,
rusty@au1.ibm.com, jkenisto@linux.vnet.ibm.com, oleg@tv-sign.ru
Subject: Re: [PATCH,RFC] Add call_rcu_sched()
Date: Tue, 8 Apr 2008 01:39:36 -0700 [thread overview]
Message-ID: <20080408013936.b84ae895.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080408081048.GA15001@in.ibm.com>
On Tue, 8 Apr 2008 13:40:48 +0530 Gautham R Shenoy <ego@in.ibm.com> wrote:
> > > + rdp = RCU_DATA_CPU(cpu);
> <-- here ------\
> > > + spin_lock_irqsave(&rdp->lock, flags); |
> > > + |
> > > + /* |
> > > + * We are running on this CPU irq-disabled, so no |
> > > + * CPU can go offline until we re-enable irqs. |
> > |
> > but, but, but. The cpu at `cpu' could have gone offline just before we |
> > disabled local interrupts. |
> |
> In that case the CPU_DEAD callback should have migrated the rcu-lists to |
> a cpu which is online. |
|
But local variable rdp might be pointing at the now-offlined CPU's data? -------/
next prev parent reply other threads:[~2008-04-08 8:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-21 14:36 [PATCH,RFC] Add call_rcu_sched() Paul E. McKenney
2008-03-21 22:40 ` Paul E. McKenney
2008-03-24 5:06 ` Mathieu Desnoyers
2008-03-24 5:46 ` Paul E. McKenney
2008-03-24 13:59 ` Mathieu Desnoyers
2008-03-25 12:53 ` [PATCH,RFC] Initialize call_rcu_sched sooner Mathieu Desnoyers
2008-03-25 18:49 ` Paul E. McKenney
2008-04-06 21:37 ` [PATCH,RFC] Add call_rcu_sched() Paul E. McKenney
2008-04-08 7:34 ` Andrew Morton
2008-04-08 8:10 ` Gautham R Shenoy
2008-04-08 8:39 ` Andrew Morton [this message]
2008-04-08 8:56 ` Gautham R Shenoy
2008-04-08 9:07 ` Andrew Morton
2008-04-08 17:17 ` Paul E. McKenney
2008-04-08 16:59 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080408013936.b84ae895.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.p.zijlstra@chello.nl \
--cc=adrian.bunk@movial.fi \
--cc=dipankar@in.ibm.com \
--cc=dsmith@redhat.com \
--cc=dvhltc@us.ibm.com \
--cc=ego@in.ibm.com \
--cc=hch@infradead.org \
--cc=jkenisto@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@polymtl.ca \
--cc=mingo@elte.hu \
--cc=mmlnx@us.ibm.com \
--cc=niv@us.ibm.com \
--cc=oleg@tv-sign.ru \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=rusty@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.