From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 08 Apr 2008 13:47:37 +0200 Subject: [U-Boot-Users] [PATCH 3/3] ppc4xx: Change Canyonlands to support booting from 2k page NAND devices In-Reply-To: Your message of "Tue, 08 Apr 2008 10:33:29 +0200." <1207643609-22495-3-git-send-email-sr@denx.de> Message-ID: <20080408114737.2AE3424842@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <1207643609-22495-3-git-send-email-sr@denx.de> you wrote: > Signed-off-by: Stefan Roese > --- > board/amcc/canyonlands/bootstrap.c | 13 +++++++++++++ > board/amcc/canyonlands/init.S | 1 + > board/amcc/canyonlands/u-boot-nand.lds | 4 ++-- > include/configs/canyonlands.h | 26 ++++++++++++++++---------- > nand_spl/board/amcc/canyonlands/config.mk | 6 +++--- > 5 files changed, 35 insertions(+), 15 deletions(-) > > diff --git a/board/amcc/canyonlands/bootstrap.c b/board/amcc/canyonlands/bootstrap.c > index 37fa1c9..1d125b6 100644 > --- a/board/amcc/canyonlands/bootstrap.c > +++ b/board/amcc/canyonlands/bootstrap.c > @@ -63,9 +63,22 @@ static u8 boot_configs[][17] = { > /* > * Bytes 5,6,8,9,11 change for NAND boot > */ > +#if 0 > +/* > + * Values for 512 page size NAND chips, not used anymore, just > + * keep them here for reference > + */ Please don't add dead code. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de When you say "I wrote a program that crashed Windows", people just stare at you blankly and say "Hey, I got those with the system, *for free*". - Linus Torvalds in <3itc77$9lj@ninurta.fer.uni-lj.si>