From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Roese Date: Tue, 8 Apr 2008 13:52:01 +0200 Subject: [U-Boot-Users] [PATCH 3/3] ppc4xx: Change Canyonlands to support booting from 2k page NAND devices In-Reply-To: <20080408114737.2AE3424842@gemini.denx.de> References: <20080408114737.2AE3424842@gemini.denx.de> Message-ID: <200804081352.01473.sr@denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tuesday 08 April 2008, Wolfgang Denk wrote: > > diff --git a/board/amcc/canyonlands/bootstrap.c > > b/board/amcc/canyonlands/bootstrap.c index 37fa1c9..1d125b6 100644 > > --- a/board/amcc/canyonlands/bootstrap.c > > +++ b/board/amcc/canyonlands/bootstrap.c > > @@ -63,9 +63,22 @@ static u8 boot_configs[][17] = { > > /* > > * Bytes 5,6,8,9,11 change for NAND boot > > */ > > +#if 0 > > +/* > > + * Values for 512 page size NAND chips, not used anymore, just > > + * keep them here for reference > > + */ > > Please don't add dead code. I was unsure about this, and kept it in as a reference for 460EX/GT boards using 512 page size NAND chips (see comment above). Such a reference is quite valuable from my point of view. How should I keep such code available? Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de =====================================================================