All of lore.kernel.org
 help / color / mirror / Atom feed
From: "John W. Linville" <linville@tuxdriver.com>
To: "Chatre, Reinette" <reinette.chatre@intel.com>
Cc: Jason Riedy <jason@acm.org>,
	ipw3945-devel@lists.sourceforge.net,
	linux-wireless@vger.kernel.org
Subject: Re: [PATCH] Make IWLCORE a silent option not to confuse iwl3945 users.
Date: Tue, 8 Apr 2008 14:04:41 -0400	[thread overview]
Message-ID: <20080408180441.GB8183@tuxdriver.com> (raw)
In-Reply-To: <D936D925018D154694D8A362EEB0892004195168@orsmsx416.amr.corp.intel.com>

On Thu, Apr 03, 2008 at 09:14:23AM -0700, Chatre, Reinette wrote:
> On Tuesday, April 01, 2008 11:29 PM,
> linux-wireless-owner@vger.kernel.org  wrote:
> 
> > The iwl3945 (currently?) does not use iwlcore.  Either the iwlcore
> > documentation should change or the option should be silent.  This
> > patch follows the latter route.  IWL4965 already SELECTs IWLCORE,
> > so there should be no new problems.  Note that IWLWIFI_DEBUGFS and
> > IWLCORE_RFKILL have no suboptions for 4965, so they are grouped
> > together and given a description that includes "4965+" to indicate
> > they're not for the 3945 adapters.
> > 
> > Signed-off-by: Jason Riedy <jason@acm.org>
> 
> We are moving to a common library for the devices and changing
> CONFIG_IWLWIFI_DEBUG to CONFIG_IWL4965_DEBUG undoes this work. Please be
> patient as we move to common code.
> 
> The numerous Kconfig variables help us to add and test the new features
> during development. They should not be there permanently.

I think it makes sense to make IWLCORE invisible, but this patch
seems not quite right.  I'm dropping it -- feel free to repost a
revised version.

Thanks,

John
-- 
John W. Linville
linville@tuxdriver.com

  reply	other threads:[~2008-04-08 18:31 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02  6:28 [PATCH] Make IWLCORE a silent option not to confuse iwl3945 users Jason Riedy
2008-04-03 16:14 ` Chatre, Reinette
2008-04-08 18:04   ` John W. Linville [this message]
2008-04-08 20:44     ` Jason Riedy
2008-04-08 22:45       ` Chatre, Reinette
2008-04-08 23:38       ` John W. Linville
2008-04-09  8:30 ` Christoph Hellwig
2008-04-09 15:38   ` [ipw3945-devel] [PATCH] Make IWLCORE a silent option not toconfuse " Chatre, Reinette

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080408180441.GB8183@tuxdriver.com \
    --to=linville@tuxdriver.com \
    --cc=ipw3945-devel@lists.sourceforge.net \
    --cc=jason@acm.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=reinette.chatre@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.