From: Jens Axboe <jens.axboe@oracle.com>
To: Mike Anderson <andmike@linux.vnet.ibm.com>
Cc: dm-devel@redhat.com
Subject: Re: [PATCH] dm: dm_table_unplug_all optimization
Date: Wed, 9 Apr 2008 10:15:23 +0200 [thread overview]
Message-ID: <20080409081522.GI12774@kernel.dk> (raw)
In-Reply-To: <20080408182100.1779.92514.stgit@desktop-andmike.beaverton.ibm.com>
On Tue, Apr 08 2008, Mike Anderson wrote:
> Performance optimization for high contention of the q->queue_lock under
> certain workloads.
>
> Signed-off-by: Mike Anderson <andmike@linux.vnet.ibm.com>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
> ---
>
> drivers/md/dm-table.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index e75b143..f4c8c1b 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -1012,7 +1012,8 @@ void dm_table_unplug_all(struct dm_table *t)
> list_for_each_entry(dd, devices, list) {
> struct request_queue *q = bdev_get_queue(dd->bdev);
>
> - blk_unplug(q);
> + if (blk_queue_plugged(q))
> + blk_unplug(q);
> }
> }
>
>
--
Jens Axboe
prev parent reply other threads:[~2008-04-09 8:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 18:20 [PATCH] dm: dm_table_unplug_all optimization Mike Anderson
2008-04-08 18:21 ` Mike Anderson
2008-04-09 8:15 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080409081522.GI12774@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=andmike@linux.vnet.ibm.com \
--cc=dm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.