From: Andy Whitcroft <apw@shadowen.org>
To: Andi Kleen <andi@firstfloor.org>
Cc: Jan Engelhardt <jengelh@computergmbh.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [patch] checkpatch: relax spacing and line length
Date: Wed, 9 Apr 2008 09:30:13 +0100 [thread overview]
Message-ID: <20080409083013.GJ17915@shadowen.org> (raw)
In-Reply-To: <20080409081943.GI17915@shadowen.org>
On Wed, Apr 09, 2008 at 09:19:43AM +0100, Andy Whitcroft wrote:
> On Tue, Apr 08, 2008 at 08:01:14PM +0200, Andi Kleen wrote:
> > Andy Whitcroft <apw@shadowen.org> writes:
> > >
> > > To justify changing checkpatch to loosen its checks I would hope to see
> > > an agreed to change to the CodingStyle detailing actually what is now
> > > acceptable.
> >
> > Here was a concrete proposal (with patch for CodingStyle) from my side some
> > time ago:
> >
> > http://article.gmane.org/gmane.linux.kernel/644306
>
> Yeah, that was a good example of how to go about changinging things. As
> I said on that thread I would happily change checkpatch to follow suit.
> Oddly for a CodingStyle discussion there was very "discussion" at all.
> It feels like people are scared of the passion that often errupts in
> discussions over style.
>
> On that particular suggestion, I would probabally be in favour, and
> slightly happier to have the string on the printk line for consistency
> even though that would violate the "don't hide information" rule.
Oh, and if people felt that the concensus was for something to be
implemented and that you are waiting for me to implement the change in
checkpatch; please say so.
-apw
next prev parent reply other threads:[~2008-04-09 8:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-06 4:54 [patch] checkpatch: relax spacing and line length Jan Engelhardt
2008-04-06 5:18 ` Andrew Morton
2008-04-06 11:52 ` Benny Halevy
2008-04-06 18:52 ` Joe Perches
2008-04-07 9:51 ` Boaz Harrosh
2008-04-06 10:08 ` Adrian Bunk
2008-04-06 11:08 ` Sam Ravnborg
2008-04-07 16:37 ` Benny Halevy
2008-04-08 17:12 ` Andy Whitcroft
2008-04-08 18:01 ` Andi Kleen
2008-04-09 8:19 ` Andy Whitcroft
2008-04-09 8:30 ` Andy Whitcroft [this message]
2008-04-09 8:46 ` Andi Kleen
2008-04-09 13:14 ` Andy Whitcroft
2008-04-09 13:18 ` Jan Engelhardt
2008-04-09 13:58 ` Andy Whitcroft
2008-04-09 16:53 ` Andrew Morton
2008-04-09 17:43 ` Andi Kleen
2008-04-09 20:07 ` Andy Whitcroft
2008-04-11 15:54 ` Andy Whitcroft
2008-04-09 15:14 ` Randy Dunlap
2008-04-09 12:10 ` Benny Halevy
2008-04-09 12:19 ` Benny Halevy
2008-04-09 13:25 ` Andy Whitcroft
2008-04-09 17:02 ` Benny Halevy
2008-04-09 17:27 ` Stefan Richter
2008-04-09 20:16 ` Andy Whitcroft
2008-04-10 23:52 ` SL Baur
2008-04-11 4:24 ` Jan Engelhardt
2008-04-12 0:26 ` Al Viro
2008-04-13 9:53 ` Benny Halevy
2008-04-13 15:18 ` Al Viro
2008-04-15 9:09 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080409083013.GJ17915@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.