From: Andy Whitcroft <apw@shadowen.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Dirk Eibach <eibach@gdsys.de>,
linux-kernel@vger.kernel.org, greg@kroah.com,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: add sysfs configuration interface for CP2101
Date: Wed, 9 Apr 2008 13:16:52 +0100 [thread overview]
Message-ID: <20080409121652.GK17915@shadowen.org> (raw)
In-Reply-To: <20080229123512.f85f417c.akpm@linux-foundation.org>
On Fri, Feb 29, 2008 at 12:35:12PM -0800, Andrew Morton wrote:
> > +static int enable_config = false;
>
> Should be either
>
> static int enable_config;
>
> or, if you're being very formal,
>
> static bool enable_config = false;
>
> or, if you're being less formal and want to avoid bloating the kernel image,
>
> static bool enable_config;
I've added detection of false as a 0 value in external and static
contexts; this should be reported in the 0.18:
ERROR: do not initialise statics to 0 or NULL
#1: FILE: Z118.c:1:
+static bool enable_config = false;
-apw
next prev parent reply other threads:[~2008-04-09 12:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 9:02 [PATCH] usb: add sysfs configuration interface for CP2101 Dirk Eibach
2008-02-29 9:40 ` Dirk Eibach
2008-02-29 10:02 ` Andrew Morton
2008-02-29 12:31 ` Dirk Eibach
2008-02-29 20:35 ` Andrew Morton
2008-03-03 9:27 ` Dirk Eibach
2008-03-03 15:07 ` Alan Stern
2008-03-03 16:28 ` Greg KH
2008-03-04 7:03 ` Dirk Eibach
2008-03-04 17:52 ` Alan Stern
2008-03-04 19:51 ` Greg KH
2008-04-09 12:16 ` Andy Whitcroft [this message]
2008-03-01 0:33 ` Greg KH
2008-02-29 14:44 ` Andy Whitcroft
2008-02-29 20:46 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080409121652.GK17915@shadowen.org \
--to=apw@shadowen.org \
--cc=akpm@linux-foundation.org \
--cc=eibach@gdsys.de \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.