From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757509AbYDJOgs (ORCPT ); Thu, 10 Apr 2008 10:36:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755882AbYDJOgk (ORCPT ); Thu, 10 Apr 2008 10:36:40 -0400 Received: from one.firstfloor.org ([213.235.205.2]:54849 "EHLO one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755757AbYDJOgj (ORCPT ); Thu, 10 Apr 2008 10:36:39 -0400 Date: Thu, 10 Apr 2008 16:41:14 +0200 From: Andi Kleen To: Steven Rostedt Cc: Andy Whitcroft , Andi Kleen , "H. Peter Anvin" , LKML , Ingo Molnar , Peter Zijlstra , Linus Torvalds , akpm@osdl.org, Rusty Russell , Glauber de Oliveira Costa , Jan Beulich , Thomas Gleixner , pinskia@gcc.gnu.org Subject: Re: [PATCH] pop previous section in alternative.c Message-ID: <20080410144114.GH10019@one.firstfloor.org> References: <47FD5D42.5000603@zytor.com> <87wsn6m6zt.fsf@basil.nowhere.org> <20080410094637.GW17915@shadowen.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > I would say anytime there's a "^+.*\.section" there had better be a > "^-.*\.section" or a "+.*.previous" matching it. Off hand I can't think o > any exceptions to this rule although I may be wrong. Second section is wrong because the compiler expects that the same section is active afterwards and that can be different ones (like init.text vs normal text) Also pushsection/popsection is also valid So in summary valid section patterns are either .section / .previous or .pushsection .section .popsection -Andi