From: "Hans J. Koch" <hjk@linutronix.de>
To: Greg KH <gregkh@suse.de>
Cc: "Hans J. Koch" <hjk@linutronix.de>,
Uwe Kleine-K??nig <Uwe.Kleine-Koenig@digi.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] UIO: hold a reference to the device's owner while the device is open
Date: Thu, 10 Apr 2008 23:23:29 +0200 [thread overview]
Message-ID: <20080410212329.GH3193@local> (raw)
In-Reply-To: <20080410211236.GA21251@suse.de>
On Thu, Apr 10, 2008 at 02:12:36PM -0700, Greg KH wrote:
> On Thu, Apr 10, 2008 at 11:02:29PM +0200, Hans J. Koch wrote:
> > On Thu, Apr 10, 2008 at 02:37:00PM +0200, Uwe Kleine-K??nig wrote:
> > > Otherwise the device might just disappear while /dev/uioX is being used
> > > which results in an Oops.
> >
> > Hi Uwe,
> > thanks for this one, good catch! Looks fine to me. There are some minor issues, see
> > below.
> > And I'd like to hear Greg's opinion: Do you agree we can omit
> > try_module_get() in uio_mmap()?
>
> If it's already been grabbed in the open() call, everything should be
> safe, right?
Yes, it looks quite clean to me. module_get in open(), module_put in
release() and nothing of that sort anywhere else. Maybe it just looked
toooo simple to me ;-)
Thanks for your confirmation.
Hans
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2008-04-10 21:23 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 12:36 [PATCH 0/4] UIO: fixes, cleanups and a new driver Uwe Kleine-König
2008-04-10 12:37 ` [PATCH 1/4] UIO: hold a reference to the device's owner while the device is open Uwe Kleine-König
2008-04-10 12:37 ` [PATCH 2/4] UIO: use menuconfig Uwe Kleine-König
2008-04-10 12:37 ` [PATCH 3/4] UIO: wrap all uio drivers in "if UIO" and "endif" Uwe Kleine-König
2008-04-10 12:37 ` [PATCH 4/4] [RFC] UIO: generic platform driver Uwe Kleine-König
2008-04-10 19:54 ` Hans J. Koch
2008-04-10 20:08 ` Uwe Kleine-König
2008-04-10 21:17 ` Hans J. Koch
2008-04-11 1:34 ` Ben Nizette
2008-04-10 22:48 ` Hans J. Koch
2008-04-11 6:21 ` Uwe Kleine-König
2008-04-11 9:21 ` [PATCH 4/4 v2] " Uwe Kleine-König
2008-04-11 10:33 ` Hans J. Koch
2008-04-11 11:03 ` Uwe Kleine-König
2008-04-11 11:17 ` Hans J. Koch
2008-04-11 11:25 ` Uwe Kleine-König
2008-04-12 13:16 ` Russell King - ARM Linux
2008-04-14 7:48 ` [PATCH] " Uwe Kleine-König
2008-04-14 9:37 ` Russell King - ARM Linux
2008-04-14 9:54 ` Uwe Kleine-König
2008-04-14 10:00 ` Uwe Kleine-König
2008-04-14 10:17 ` Russell King - ARM Linux
2008-04-14 11:20 ` Uwe Kleine-König
2008-04-14 11:37 ` Russell King - ARM Linux
2008-04-14 11:52 ` Hans J. Koch
2008-04-11 10:48 ` Uwe Kleine-König
2008-04-11 21:41 ` Greg KH
2008-04-11 22:54 ` Hans J. Koch
2008-04-11 23:06 ` Greg KH
2008-04-11 9:24 ` [PATCH 4/4] " Hans J. Koch
2008-04-11 10:41 ` Uwe Kleine-König
2008-04-11 19:59 ` Hans J. Koch
2008-04-10 19:45 ` [PATCH 3/4] UIO: wrap all uio drivers in "if UIO" and "endif" Hans J. Koch
2008-04-11 21:36 ` Greg KH
2008-04-10 19:39 ` [PATCH 2/4] UIO: use menuconfig Hans J. Koch
2008-04-11 21:36 ` Greg KH
2008-04-11 22:58 ` Hans J. Koch
2008-04-10 20:11 ` [PATCH 1/4] UIO: hold a reference to the device's owner while the device is open Uwe Kleine-König
2008-04-10 21:02 ` Hans J. Koch
2008-04-10 21:12 ` Greg KH
2008-04-10 21:23 ` Hans J. Koch [this message]
2008-04-11 6:50 ` Uwe Kleine-König
2008-04-11 8:44 ` Hans J. Koch
2008-04-11 9:07 ` [PATCH 1/4 v2] " Uwe Kleine-König
2008-04-11 11:39 ` Hans J. Koch
2008-04-22 9:47 ` [PATCH 0/3] UIO: cleanup and platform driver Uwe Kleine-König
2008-04-22 9:52 ` [PATCH 1/3] UIO: don't let UIO_CIF and UIO_SMX depend twice on UIO Uwe Kleine-König
2008-04-22 9:52 ` [PATCH 2/3] provide a dummy implementation of the clk API Uwe Kleine-König
2008-04-22 9:52 ` [PATCH 3/3] UIO: generic platform driver Uwe Kleine-König
2008-04-22 10:26 ` Ben Nizette
2008-04-22 13:35 ` Hans J. Koch
2008-04-23 8:56 ` Uwe Kleine-König
2008-04-27 17:12 ` Hans J. Koch
2008-05-20 9:23 ` Uwe Kleine-König
2008-05-20 9:24 ` [PATCH] UIO: don't let UIO_CIF and UIO_SMX depend twice on UIO Uwe Kleine-König
2008-05-20 9:24 ` [PATCH] UIO: generic platform driver Uwe Kleine-König
2008-05-20 21:08 ` Hans J. Koch
2008-05-26 5:58 ` Uwe Kleine-König
2008-05-26 6:02 ` Greg KH
2008-05-30 9:16 ` Uwe Kleine-König
2008-05-30 16:35 ` Greg KH
2008-06-03 7:21 ` Uwe Kleine-König
2008-06-03 9:24 ` Hans J. Koch
2008-05-20 21:12 ` [PATCH] UIO: don't let UIO_CIF and UIO_SMX depend twice on UIO Hans J. Koch
2008-04-22 13:39 ` [PATCH 0/3] UIO: cleanup and platform driver Hans J. Koch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080410212329.GH3193@local \
--to=hjk@linutronix.de \
--cc=Uwe.Kleine-Koenig@digi.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.