From: David Brownell <david-b@pacbell.net>
To: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] GPIO: #include <linux/kernel.h> for might_sleep
Date: Fri, 11 Apr 2008 10:05:51 -0700 [thread overview]
Message-ID: <200804111005.52041.david-b@pacbell.net> (raw)
In-Reply-To: <1207902290-25381-1-git-send-email-Uwe.Kleine-Koenig@digi.com>
On Friday 11 April 2008, Uwe Kleine-König wrote:
> I like having headers being independend of the order of inclusion.
That's a pretty unusual policy. Not one that's generally
followed in the kernel, either ...
> Usually I order all includes alphabetically (and grouped by linux/,
> asm/, etc.).
If you like alphabetical, why the exception for <asm/...> ??
:)
> This doesn't work with gpio.h because then kernel.h is
> included to late.
So include <linux/kernel.h> first. There *is* a policy
of avoiding extra #includes ... extras slow down builds.
- Dave
next prev parent reply other threads:[~2008-04-11 17:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 8:24 [PATCH] GPIO: #include <linux/kernel.h> for might_sleep Uwe Kleine-König
2008-04-11 10:46 ` Uwe Kleine-König
2008-04-11 17:05 ` David Brownell [this message]
2008-04-15 7:36 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804111005.52041.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=Uwe.Kleine-Koenig@digi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.