From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from naru.obs2.net ([84.20.150.76] helo=narury.org) by bombadil.infradead.org with esmtps (Exim 4.68 #1 (Red Hat Linux)) id 1JkH60-0004Kt-01 for linux-mtd@lists.infradead.org; Fri, 11 Apr 2008 11:07:04 +0000 Date: Fri, 11 Apr 2008 14:07:02 +0300 From: Riku Voipio To: Joakim Tjernlund Subject: Re: [PATCH] compr_lzo.c: allocate enough memory for lzo compressor. Message-ID: <20080411110702.GA15263@kos.to> References: <20080411093337.GA22045@kos.to> <1207911122.9544.29.camel@gentoo-jocke.transmode.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1207911122.9544.29.camel@gentoo-jocke.transmode.se> Cc: linux-mtd@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, Apr 11, 2008 at 12:52:02PM +0200, Joakim Tjernlund wrote: > > On Fri, 2008-04-11 at 12:33 +0300, Riku Voipio wrote: > > This is the same bug as in kernel, pointed out the LZO author > > (Markus Oberhumer): > > > > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=f2a11b158a24301e9158e9c873fa88e5eb775486 > > --- > > compr_lzo.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/compr_lzo.c b/compr_lzo.c > > index fb54600..a0bb362 100644 > > --- a/compr_lzo.c > > +++ b/compr_lzo.c > > @@ -97,7 +97,7 @@ int jffs2_lzo_init(void) > > return -1; > > > > /* Worse case LZO compression size from their FAQ */ > > - lzo_compress_buf = malloc(page_size + (page_size / 64) + 16 + 3); > > + lzo_compress_buf = malloc(page_size + (page_size / 16) + 64 + 3); > > if (!lzo_compress_buf) { > > free(lzo_mem); > > return -1; > I think you should use lzo1x_worst_compress() from the link you posted > above. lzo1x_worst_compress() is in the kernel header, while patch is for the userland mtd-utils. The kernel header doesn't seem to get installed with make headers_install, so I can't use it from userland. Also, liblzo2 headers don't provide such function (although IMO they should). -- "rm -rf" only sounds scary if you don't have backups