From: Nick Andrew <nick@nick-andrew.net>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: [RFC] x86: Cleanup prose of Documentation/i386/IO-APIC.txt
Date: Sat, 12 Apr 2008 01:40:53 +1000 [thread overview]
Message-ID: <20080411154053.GD18242@tull.net> (raw)
I'm doing a couple of cleanups to Documentation/i386/IO-APIC.txt
and I have a problem with this line, which is supposed to compute
a sample pirq= kernel parameter:
echo -n pirq=; echo `scanpci | grep T_L | cut -c56-` | sed 's/ /,/g'
The 'scanpci' command used to be part of xutils and/or XFree86.
Xorg implements "Xorg -scanpci" but the output is different and it won't
run while X is running.
Firstly I propose using the $( ) construct rather than backticks, since
it is easier to read:
echo -n pirq=; echo $( scanpci | grep T_L | cut -c56- ) | sed 's/ /,/g'
Inside the backtics, instead of scanpci, I could do:
lspci -v | grep IRQ | sed -e 's/.* IRQ \(\w\+\)/\1/'
Is this an acceptable substitution?
Nick.
--
PGP Key ID = 0x418487E7 http://www.nick-andrew.net/
PGP Key fingerprint = B3ED 6894 8E49 1770 C24A 67E3 6266 6EB9 4184 87E7
next reply other threads:[~2008-04-11 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 15:40 Nick Andrew [this message]
2008-04-13 8:45 ` [RFC] x86: Cleanup prose of Documentation/i386/IO-APIC.txt Ingo Molnar
2008-04-13 11:25 ` Nick Andrew
2008-04-14 9:46 ` Ingo Molnar
2008-04-14 10:17 ` Nick Andrew
2008-04-14 10:28 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411154053.GD18242@tull.net \
--to=nick@nick-andrew.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.