From: Andreas Dilger <adilger@sun.com>
To: Girish Shilamkar <Girish.Shilamkar@sun.com>
Cc: Ext4 Mailing List <linux-ext4@vger.kernel.org>,
Theodore Tso <tytso@mit.edu>
Subject: Re: Entries in feature_list[]
Date: Sat, 12 Apr 2008 21:49:57 -0600 [thread overview]
Message-ID: <20080413034957.GA8058@webber.adilger.int> (raw)
In-Reply-To: <1206603634.3379.4.camel@alpha.linsyssoft.com>
On Mar 27, 2008 13:10 +0530, Girish Shilamkar wrote:
> In e2fsprogs/lib/e2p/feature.c
> struct feature feature_list[] contains:
> ...
> { E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
> "extents" },
> { E2P_FEATURE_INCOMPAT, EXT2_FEATURE_INCOMPAT_META_BG,
> "meta_bg" }
> { E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS,
> "extent" },
> ...
>
> Is the { E2P_*, EXT3_*, "extent"} entry correct one, if yes, what is the purpose behind having two
> {E2P_FEATURE_INCOMPAT, EXT3_FEATURE_INCOMPAT_EXTENTS, *} entries, unless we want "extent" to be
> correct feature ?
This is probably a merge error, or maybe a convenice measure to allow both
"extent" and "extents"? We need something similar for "uninit_groups"
and the new "uninit_bg".
Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.
prev parent reply other threads:[~2008-04-13 3:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 7:40 Entries in feature_list[] Girish Shilamkar
2008-04-13 3:49 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080413034957.GA8058@webber.adilger.int \
--to=adilger@sun.com \
--cc=Girish.Shilamkar@sun.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.