From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1Jl0g2-0006HT-8j for mharc-grub-devel@gnu.org; Sun, 13 Apr 2008 07:47:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Jl0g0-0006HG-3W for grub-devel@gnu.org; Sun, 13 Apr 2008 07:47:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Jl0fy-0006H0-VJ for grub-devel@gnu.org; Sun, 13 Apr 2008 07:47:15 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Jl0fy-0006Gv-QQ for grub-devel@gnu.org; Sun, 13 Apr 2008 07:47:14 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Jl0fy-0005lD-H1 for grub-devel@gnu.org; Sun, 13 Apr 2008 07:47:14 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1Jl0fw-0006My-AK; Sun, 13 Apr 2008 13:47:12 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1Jl0fX-0005la-M1; Sun, 13 Apr 2008 13:46:47 +0200 Date: Sun, 13 Apr 2008 13:46:47 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080413114647.GF20737@thorin> References: <47F7643D.2070204@t-online.de> <20080406132131.jlcomedo2og0ocwc@webmail.spamcop.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080406132131.jlcomedo2og0ocwc@webmail.spamcop.net> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Cc: Christian Franke Subject: Re: Infinite loop regression due to recent change in hostfs.c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 13 Apr 2008 11:47:16 -0000 On Sun, Apr 06, 2008 at 01:21:31PM -0400, Pavel Roskin wrote: > Quoting Christian Franke : > > >The change in hostfs.c introduces an interesting regression: hostfs now > >appears in *_init.lst and grub_hostfs_init() is called twice in > >grub-emu and grub-fstest. This results in a infinite loop because the > >hostfs entry of grub_fs_list points to itself. > > Thanks for noticing the problem and for the analysis! > > >You should either undo this change or remove extra calls to > >grub_hostfs_init/fini from grub-emu.c and grub-fstest.c. The latter > >might not work if it is necessary to init hostfs first for some reason. > > I've removed the extra calls. I don't see any reasons why hostfs > should be registered first. I suspect it was a remnant from before we had grub_init_all(). -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)